Cleanup of browser_test harness.

-share the browser startup code with chrome. Apart from the benefit of making browser_tests more like Chrome, this allows us to write browser_tests that test app mode etc.
-get rid of InProcessBrowserTest::set_initial_window_required now that the above is done
-get rid of InProcessBrowserTest::set_show_window which didn't do anything
-get rid of --disable-tab-closeable-state-watcher which was set by a chromeos test but not used anywhere

I had to create the Mac autorelease pool object a little earlier, since it must be created before the first Browser window is created (which used to happen in InProcessBrowserTest::RunTestOnMainThreadLoop but now happens in BrowserTestBase::SetUp()).
Review URL: https://chromiumcodereview.appspot.com/10278003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135164 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 0 insertions, 2 deletions

diff --git a/chrome/browser/debugger/devtools_sanity_unittest.cc b/chrome/browser/debugger/devtools_sanity_unittest.cc
index 9d6e10d..128004d 100644
--- a/chrome/browser/debugger/devtools_sanity_unittest.cc
+++ b/chrome/browser/debugger/devtools_sanity_unittest.cc
@@ -122,7 +122,6 @@ class DevToolsSanityTest : public InProcessBrowserTest {
   DevToolsSanityTest()
       : window_(NULL),
         inspected_rvh_(NULL) {
-    set_show_window(true);
     EnableDOMAutomation();
   }
 
@@ -271,7 +270,6 @@ class DevToolsExperimentalExtensionTest : public DevToolsExtensionTest {
 class WorkerDevToolsSanityTest : public InProcessBrowserTest {
  public:
   WorkerDevToolsSanityTest() : window_(NULL) {
-    set_show_window(true);
     EnableDOMAutomation();
   }