diff options
author | yurys@google.com <yurys@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-23 10:43:58 +0000 |
---|---|---|
committer | yurys@google.com <yurys@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-23 10:43:58 +0000 |
commit | 7aa27fdf4e135daef7f49a37a61e506c165ce214 (patch) | |
tree | 20005ed71165173cd988d655a9534765439848ef /chrome/browser/debugger/devtools_window.h | |
parent | 7197f4999afa5e767fa9ed76fdc7e67db080f9d2 (diff) | |
download | chromium_src-7aa27fdf4e135daef7f49a37a61e506c165ce214.zip chromium_src-7aa27fdf4e135daef7f49a37a61e506c165ce214.tar.gz chromium_src-7aa27fdf4e135daef7f49a37a61e506c165ce214.tar.bz2 |
Currently we have two types of devtools UI: Chrome built in developer tools window and remote debugger connected over TCP(apavlov is working on it). To allow DevToolsManager coordinate both types of devtools uniformly their API is extracted into DevToolsClientHost interface.
Fix purify errors in DevToolsManager unit tests.
BUG=9150
Review URL: http://codereview.chromium.org/50009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12274 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/debugger/devtools_window.h')
-rw-r--r-- | chrome/browser/debugger/devtools_window.h | 27 |
1 files changed, 12 insertions, 15 deletions
diff --git a/chrome/browser/debugger/devtools_window.h b/chrome/browser/debugger/devtools_window.h index 257c44d..da13ae2 100644 --- a/chrome/browser/debugger/devtools_window.h +++ b/chrome/browser/debugger/devtools_window.h @@ -6,32 +6,29 @@ #define CHROME_BROWSER_DEBUGGER_DEV_TOOLS_WINDOW_H_ #include "base/basictypes.h" +#include "chrome/browser/debugger/devtools_client_host.h" -class DevToolsInstanceDescriptor; +class RenderViewHost; -class DevToolsWindow { +class DevToolsWindow : public DevToolsClientHost { public: - static DevToolsWindow* Create(DevToolsInstanceDescriptor* descriptor); + // Factory method for creating platform specific devtools windows. + static DevToolsWindow* Create(); + virtual ~DevToolsWindow() {} - // Show developer tools window. + // Show this window. virtual void Show() = 0; - virtual void Close() = 0; + virtual bool HasRenderViewHost(const RenderViewHost& rvh) const = 0; + + // DevToolsClientHost override. + virtual DevToolsWindow* AsDevToolsWindow() { return this; } protected: - DevToolsWindow() {} + DevToolsWindow() : DevToolsClientHost() {} private: DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); }; -// Factory for creating DevToolsWindows. Useful for unit tests. -class DevToolsWindowFactory { - public: - virtual ~DevToolsWindowFactory() {} - virtual DevToolsWindow* CreateDevToolsWindow( - DevToolsInstanceDescriptor* descriptor) = 0; -}; - - #endif // CHROME_BROWSER_DEBUGGER_DEV_TOOLS_WINDOW_H_ |