diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-04 23:11:19 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-04 23:11:19 +0000 |
commit | 9b2331d912b0a15c3eef290eaa617c54a87dc68e (patch) | |
tree | 6ca5f0248ce754b74b39112c17c2d9726c004e79 /chrome/browser/debugger | |
parent | 9f1e5d235d5bdb3a0fe626fe47f5468cddaf75e4 (diff) | |
download | chromium_src-9b2331d912b0a15c3eef290eaa617c54a87dc68e.zip chromium_src-9b2331d912b0a15c3eef290eaa617c54a87dc68e.tar.gz chromium_src-9b2331d912b0a15c3eef290eaa617c54a87dc68e.tar.bz2 |
Reapply r61237: FBTF: Another big ctor/dtor cleanup found by automated tools.
Removes changes to code in webkit/ that broke chrome_frame. Will debug that portion later.
(Shaves ~2MB off Linux Debug .a files)
BUG=none
TEST=compiles
First Review URL: http://codereview.chromium.org/3563004
Review URL: http://codereview.chromium.org/3621003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61435 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/debugger')
-rw-r--r-- | chrome/browser/debugger/devtools_remote_message.cc | 10 | ||||
-rw-r--r-- | chrome/browser/debugger/devtools_remote_message.h | 8 | ||||
-rw-r--r-- | chrome/browser/debugger/inspectable_tab_proxy.cc | 16 | ||||
-rw-r--r-- | chrome/browser/debugger/inspectable_tab_proxy.h | 14 |
4 files changed, 34 insertions, 14 deletions
diff --git a/chrome/browser/debugger/devtools_remote_message.cc b/chrome/browser/debugger/devtools_remote_message.cc index eb63009..6d82a28 100644 --- a/chrome/browser/debugger/devtools_remote_message.cc +++ b/chrome/browser/debugger/devtools_remote_message.cc @@ -17,6 +17,16 @@ DevToolsRemoteMessageBuilder& DevToolsRemoteMessageBuilder::instance() { return instance_; } +DevToolsRemoteMessage::DevToolsRemoteMessage() {} + +DevToolsRemoteMessage::DevToolsRemoteMessage(const HeaderMap& headers, + const std::string& content) + : header_map_(headers), + content_(content) { +} + +DevToolsRemoteMessage::~DevToolsRemoteMessage() {} + const std::string DevToolsRemoteMessage::GetHeader( const std::string& header_name, const std::string& default_value) const { diff --git a/chrome/browser/debugger/devtools_remote_message.h b/chrome/browser/debugger/devtools_remote_message.h index bea9ae5..e836164 100644 --- a/chrome/browser/debugger/devtools_remote_message.h +++ b/chrome/browser/debugger/devtools_remote_message.h @@ -35,11 +35,9 @@ class DevToolsRemoteMessage { static const char kEmptyValue[]; // Constructs an empty message with no content or headers. - DevToolsRemoteMessage() {} - DevToolsRemoteMessage(const HeaderMap& headers, const std::string& content) - : header_map_(headers), - content_(content) {} - virtual ~DevToolsRemoteMessage() {} + DevToolsRemoteMessage(); + DevToolsRemoteMessage(const HeaderMap& headers, const std::string& content); + virtual ~DevToolsRemoteMessage(); const HeaderMap& headers() const { return header_map_; diff --git a/chrome/browser/debugger/inspectable_tab_proxy.cc b/chrome/browser/debugger/inspectable_tab_proxy.cc index 96d4e3e..ce8fd7f 100644 --- a/chrome/browser/debugger/inspectable_tab_proxy.cc +++ b/chrome/browser/debugger/inspectable_tab_proxy.cc @@ -15,6 +15,18 @@ #include "chrome/browser/tabs/tab_strip_model.h" #include "chrome/common/devtools_messages.h" +DevToolsClientHostImpl::DevToolsClientHostImpl( + int32 id, + DebuggerRemoteService* service, + InspectableTabProxy::IdToClientHostMap* map) + : id_(id), + service_(service), + map_(map) {} + +DevToolsClientHostImpl::~DevToolsClientHostImpl() { + map_->erase(this->id_); +} + // The debugged tab has closed. void DevToolsClientHostImpl::InspectedTabClosing() { TabClosed(); @@ -49,6 +61,10 @@ void DevToolsClientHostImpl::TabClosed() { service_->TabClosed(id_); } +InspectableTabProxy::InspectableTabProxy() {} + +InspectableTabProxy::~InspectableTabProxy() {} + const InspectableTabProxy::ControllersMap& InspectableTabProxy::controllers_map() { controllers_map_.clear(); diff --git a/chrome/browser/debugger/inspectable_tab_proxy.h b/chrome/browser/debugger/inspectable_tab_proxy.h index af08232..8d02727 100644 --- a/chrome/browser/debugger/inspectable_tab_proxy.h +++ b/chrome/browser/debugger/inspectable_tab_proxy.h @@ -26,8 +26,8 @@ class InspectableTabProxy { typedef base::hash_map<int32, NavigationController*> ControllersMap; typedef base::hash_map<int32, DevToolsClientHostImpl*> IdToClientHostMap; - InspectableTabProxy() {} - virtual ~InspectableTabProxy() {} + InspectableTabProxy(); + virtual ~InspectableTabProxy(); // Returns a map of NavigationControllerKeys to NavigationControllers // for all Browser instances. Clients should not keep the result around @@ -64,13 +64,9 @@ class DevToolsClientHostImpl : public DevToolsClientHost { DevToolsClientHostImpl( int32 id, DebuggerRemoteService* service, - InspectableTabProxy::IdToClientHostMap* map) - : id_(id), - service_(service), - map_(map) {} - ~DevToolsClientHostImpl() { - map_->erase(this->id_); - } + InspectableTabProxy::IdToClientHostMap* map); + ~DevToolsClientHostImpl(); + DebuggerRemoteService* debugger_remote_service() { return service_; } |