diff options
author | maruel@google.com <maruel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-15 12:27:03 +0000 |
---|---|---|
committer | maruel@google.com <maruel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-15 12:27:03 +0000 |
commit | 1eb89e8fbf2d31247f5ceb271d8887a63d4a2bcf (patch) | |
tree | b78be07dbada3ac0f6d2435558e4a6aaba198ffc /chrome/browser/debugger | |
parent | ea15e98a9353494df754a11fb49f0e4b8c0d4789 (diff) | |
download | chromium_src-1eb89e8fbf2d31247f5ceb271d8887a63d4a2bcf.zip chromium_src-1eb89e8fbf2d31247f5ceb271d8887a63d4a2bcf.tar.gz chromium_src-1eb89e8fbf2d31247f5ceb271d8887a63d4a2bcf.tar.bz2 |
Large patch set (159 files total) to cleanup the includes.
- Slightly reduce the size of the generated .lib files ~3%.
- Reduce the number of implicit and explicit atl and windows includes. hooray!
- Help incremental build by reducing the number of unnecessary included files.
- Split some template class in two, one base class for the common code and the specialization that inherits from the base class.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@937 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/debugger')
-rw-r--r-- | chrome/browser/debugger/debugger_io.h | 14 | ||||
-rw-r--r-- | chrome/browser/debugger/debugger_node.cc | 3 | ||||
-rw-r--r-- | chrome/browser/debugger/debugger_wrapper.h | 22 |
3 files changed, 22 insertions, 17 deletions
diff --git a/chrome/browser/debugger/debugger_io.h b/chrome/browser/debugger/debugger_io.h index 6d6e792..7408c62 100644 --- a/chrome/browser/debugger/debugger_io.h +++ b/chrome/browser/debugger/debugger_io.h @@ -27,15 +27,18 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -#ifndef CHROME_BROWSER_DEBUGGER_DEBUGGER_IO_H__ -#define CHROME_BROWSER_DEBUGGER_DEBUGGER_IO_H__ +#ifndef CHROME_BROWSER_DEBUGGER_DEBUGGER_IO_H_ +#define CHROME_BROWSER_DEBUGGER_DEBUGGER_IO_H_ + +#include <string> #include "base/basictypes.h" #include "base/ref_counted.h" class DebuggerShell; -class DebuggerInputOutput: public base::RefCountedThreadSafe<DebuggerInputOutput> { +class DebuggerInputOutput + : public base::RefCountedThreadSafe<DebuggerInputOutput> { public: DebuggerInputOutput() {} virtual ~DebuggerInputOutput() {} @@ -65,8 +68,7 @@ protected: DebuggerShell* debugger_; private: - - DISALLOW_EVIL_CONSTRUCTORS(DebuggerInputOutput); + DISALLOW_COPY_AND_ASSIGN(DebuggerInputOutput); }; -#endif // CHROME_BROWSER_DEBUGGER_DEBUGGER_IO_H__
\ No newline at end of file +#endif // CHROME_BROWSER_DEBUGGER_DEBUGGER_IO_H_
\ No newline at end of file diff --git a/chrome/browser/debugger/debugger_node.cc b/chrome/browser/debugger/debugger_node.cc index 6ae0c49..885bb82 100644 --- a/chrome/browser/debugger/debugger_node.cc +++ b/chrome/browser/debugger/debugger_node.cc @@ -27,7 +27,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -#include "debugger_node.h" +#include "chrome/browser/debugger/debugger_node.h" #include "base/process_util.h" #include "base/string_util.h" @@ -36,6 +36,7 @@ #include "chrome/browser/browser_process.h" #include "chrome/browser/render_process_host.h" #include "chrome/browser/render_view_host.h" +#include "chrome/browser/web_contents.h" #include "chrome/browser/debugger/debugger_shell.h" DebuggerNode::DebuggerNode() : valid_(true), observing_(false), data_(NULL) { diff --git a/chrome/browser/debugger/debugger_wrapper.h b/chrome/browser/debugger/debugger_wrapper.h index 92d9c6c..33ba584 100644 --- a/chrome/browser/debugger/debugger_wrapper.h +++ b/chrome/browser/debugger/debugger_wrapper.h @@ -32,15 +32,18 @@ // Debugger needed, add new wrapper methods to this file. // // This is a workaround to enable the Debugger without breaking the KJS build. -// It wraps all methods in Debugger which are called from outside of the debugger -// project. Each solution has its own project with debugger files. KJS has only -// debugger_wrapper* and debugger.h, and defines CHROME_DEBUGGER_DISABLED, which makes -// it compile only a stub version of Debugger that doesn't reference V8. Meanwhile -// the V8 solution includes all of the debugger files without CHROME_DEBUGGER_DISABLED -// so the full functionality is enabled. +// It wraps all methods in Debugger which are called from outside of the +// debugger project. Each solution has its own project with debugger files. +// KJS has only debugger_wrapper* and debugger.h, and defines +// CHROME_DEBUGGER_DISABLED, which makes it compile only a stub version of +// Debugger that doesn't reference V8. Meanwhile the V8 solution includes all +// of the debugger files without CHROME_DEBUGGER_DISABLED so the full +// functionality is enabled. -#ifndef CHROME_BROWSER_DEBUGGER_DEBUGGER_INTERFACE_H__ -#define CHROME_BROWSER_DEBUGGER_DEBUGGER_INTERFACE_H__ +#ifndef CHROME_BROWSER_DEBUGGER_DEBUGGER_INTERFACE_H_ +#define CHROME_BROWSER_DEBUGGER_DEBUGGER_INTERFACE_H_ + +#include <string> #include "base/basictypes.h" #include "base/ref_counted.h" @@ -64,5 +67,4 @@ class DebuggerWrapper : public base::RefCountedThreadSafe<DebuggerWrapper> { scoped_refptr<DebuggerShell> debugger_; }; - -#endif // CHROME_BROWSER_DEBUGGER_DEBUGGER_INTERFACE_H__
\ No newline at end of file +#endif // CHROME_BROWSER_DEBUGGER_DEBUGGER_INTERFACE_H_
\ No newline at end of file |