summaryrefslogtreecommitdiffstats
path: root/chrome/browser/debugger
diff options
context:
space:
mode:
authorthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-01 16:24:55 +0000
committerthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-01 16:24:55 +0000
commit8be8294d1b808cc713241b7255d2ce3ebbed4718 (patch)
tree100287e38fe6924ffe5db5488dbe64b5d7df1ced /chrome/browser/debugger
parent1758e88fd909ea0ffd49621e8066ffad5627ffdf (diff)
downloadchromium_src-8be8294d1b808cc713241b7255d2ce3ebbed4718.zip
chromium_src-8be8294d1b808cc713241b7255d2ce3ebbed4718.tar.gz
chromium_src-8be8294d1b808cc713241b7255d2ce3ebbed4718.tar.bz2
Use make_scoped_refptr for NewRunnableMethod if the raw ptr type is derived from RefCountedThreadSafe
Like http://codereview.chromium.org/4053006 , but for all of chrome. This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2809041. I manually fixed the one presubmit warning the rewriter introduced. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4188008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64614 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/debugger')
-rw-r--r--chrome/browser/debugger/devtools_http_protocol_handler.cc8
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/browser/debugger/devtools_http_protocol_handler.cc b/chrome/browser/debugger/devtools_http_protocol_handler.cc
index 5f01335..307aa84 100644
--- a/chrome/browser/debugger/devtools_http_protocol_handler.cc
+++ b/chrome/browser/debugger/devtools_http_protocol_handler.cc
@@ -95,7 +95,7 @@ void DevToolsHttpProtocolHandler::OnHttpRequest(
FROM_HERE,
NewRunnableMethod(this,
&DevToolsHttpProtocolHandler::OnHttpRequestUI,
- socket,
+ make_scoped_refptr(socket),
info));
return;
}
@@ -123,7 +123,7 @@ void DevToolsHttpProtocolHandler::OnWebSocketRequest(
NewRunnableMethod(
this,
&DevToolsHttpProtocolHandler::OnWebSocketRequestUI,
- socket,
+ make_scoped_refptr(socket),
request));
}
@@ -135,7 +135,7 @@ void DevToolsHttpProtocolHandler::OnWebSocketMessage(HttpListenSocket* socket,
NewRunnableMethod(
this,
&DevToolsHttpProtocolHandler::OnWebSocketMessageUI,
- socket,
+ make_scoped_refptr(socket),
data));
}
@@ -154,6 +154,8 @@ void DevToolsHttpProtocolHandler::OnClose(HttpListenSocket* socket) {
socket_to_requests_io_.erase(socket);
}
+ // This can't use make_scoped_refptr because |socket| is already deleted
+ // when this runs -- http://crbug.com/59930
BrowserThread::PostTask(
BrowserThread::UI,
FROM_HERE,