diff options
| author | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-21 17:06:29 +0000 |
|---|---|---|
| committer | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-21 17:06:29 +0000 |
| commit | f0fd71aef0ae87406debeb063e018e475e35e69f (patch) | |
| tree | ea574c366ae5243e9e9e1dbcbb9aa21d49a95113 /chrome/browser/debugger | |
| parent | 917f58b57be703febf37d09be8a388cbc12f2747 (diff) | |
| download | chromium_src-f0fd71aef0ae87406debeb063e018e475e35e69f.zip chromium_src-f0fd71aef0ae87406debeb063e018e475e35e69f.tar.gz chromium_src-f0fd71aef0ae87406debeb063e018e475e35e69f.tar.bz2 | |
DevTools: Provide nice initial location/size for the devtools window.
Review URL: http://codereview.chromium.org/113704
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16613 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/debugger')
| -rw-r--r-- | chrome/browser/debugger/devtools_window.cc | 29 |
1 files changed, 21 insertions, 8 deletions
diff --git a/chrome/browser/debugger/devtools_window.cc b/chrome/browser/debugger/devtools_window.cc index 7ac6c05..ef82130 100644 --- a/chrome/browser/debugger/devtools_window.cc +++ b/chrome/browser/debugger/devtools_window.cc @@ -21,16 +21,29 @@ DevToolsWindow::DevToolsWindow(Profile* profile) : TabStripModelObserver(), inspected_tab_closing_(false) { - static bool g_prefs_registered = false; - if (!g_prefs_registered) { - std::wstring window_pref(prefs::kBrowserWindowPlacement); - window_pref.append(L"_"); - window_pref.append(L"DevToolsApp"); + static std::wstring g_wp_key = L""; + if (g_wp_key.empty()) { + // TODO(pfeldman): Make browser's getter for this key static. + g_wp_key.append(prefs::kBrowserWindowPlacement); + g_wp_key.append(L"_"); + g_wp_key.append(L"DevToolsApp"); + PrefService* prefs = g_browser_process->local_state(); - prefs->RegisterDictionaryPref(window_pref.c_str()); - g_prefs_registered = true; + prefs->RegisterDictionaryPref(g_wp_key.c_str()); + + const DictionaryValue* wp_pref = prefs->GetDictionary(g_wp_key.c_str()); + if (!wp_pref) { + DictionaryValue* defaults = prefs->GetMutableDictionary(
+ g_wp_key.c_str());
+ defaults->SetInteger(L"left", 100);
+ defaults->SetInteger(L"top", 100);
+ defaults->SetInteger(L"right", 740);
+ defaults->SetInteger(L"bottom", 740);
+ defaults->SetBoolean(L"maximized", false);
+ defaults->SetBoolean(L"always_on_top", false);
+ } } - + browser_.reset(Browser::CreateForApp(L"DevToolsApp", profile, false)); GURL contents(std::string(chrome::kChromeUIDevToolsURL) + "devtools.html"); browser_->AddTabWithURL(contents, GURL(), PageTransition::START_PAGE, true, |