diff options
author | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-01 22:17:54 +0000 |
---|---|---|
committer | cpu@google.com <cpu@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-01 22:17:54 +0000 |
commit | 0e095be478b9205fe1a6725ac6eebf2de7185c8d (patch) | |
tree | d280c8fbb3c4bda0b1a0baad0da8b8d9c8a9cbd2 /chrome/browser/debugger | |
parent | db4423add141deeaaff952fbd46d89ab005d7bd2 (diff) | |
download | chromium_src-0e095be478b9205fe1a6725ac6eebf2de7185c8d.zip chromium_src-0e095be478b9205fe1a6725ac6eebf2de7185c8d.tar.gz chromium_src-0e095be478b9205fe1a6725ac6eebf2de7185c8d.tar.bz2 |
Coverity underground warfare: check return code
- Check return code consistently
- NOTREACHED() added in one case
- CID 4169
BUG = none
TEST = none
Review URL: http://codereview.chromium.org/118042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17360 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/debugger')
-rw-r--r-- | chrome/browser/debugger/inspectable_tab_proxy.cc | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/chrome/browser/debugger/inspectable_tab_proxy.cc b/chrome/browser/debugger/inspectable_tab_proxy.cc index 064ee8f..7d584dc 100644 --- a/chrome/browser/debugger/inspectable_tab_proxy.cc +++ b/chrome/browser/debugger/inspectable_tab_proxy.cc @@ -52,12 +52,16 @@ void DevToolsClientHostImpl::OnRpcMessage(const std::string& class_name, ListValue* list_msg = static_cast<ListValue*>(message.get()); if (class_name == kDebuggerAgentDelegate && message_name == kDebuggerOutput) { std::string str; - list_msg->GetString(0, &str); + if (!list_msg->GetString(0, &str)) + return; DebuggerOutput(str); } else if (class_name == kToolsAgentDelegate && message_name == kFrameNavigate) { std::string url; - list_msg->GetString(0, &url); + if (!list_msg->GetString(0, &url)) { + NOTREACHED(); + return; + } FrameNavigate(url); } } |