diff options
author | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-27 23:01:50 +0000 |
---|---|---|
committer | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-27 23:01:50 +0000 |
commit | c058805b99cce98cbc352c499f3e69fd355a84c2 (patch) | |
tree | 93fb4ffdf5daf4d8ae0e3291919a074a8b9e58a7 /chrome/browser/debugger | |
parent | f07cc2ebf950cb22c5c386f95a1be0292de4db3b (diff) | |
download | chromium_src-c058805b99cce98cbc352c499f3e69fd355a84c2.zip chromium_src-c058805b99cce98cbc352c499f3e69fd355a84c2.tar.gz chromium_src-c058805b99cce98cbc352c499f3e69fd355a84c2.tar.bz2 |
Plumb the referrer throughout the OpenURL APIs.
http://code.google.com/p/chromium/issues/detail?id=3224
Caveats:
* Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer.
* Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.)
* Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version.
Review URL: http://codereview.chromium.org/8186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4036 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/debugger')
-rw-r--r-- | chrome/browser/debugger/debugger_view.cc | 7 | ||||
-rw-r--r-- | chrome/browser/debugger/debugger_view.h | 1 |
2 files changed, 6 insertions, 2 deletions
diff --git a/chrome/browser/debugger/debugger_view.cc b/chrome/browser/debugger/debugger_view.cc index 9cbe4f4..89cb4e8 100644 --- a/chrome/browser/debugger/debugger_view.cc +++ b/chrome/browser/debugger/debugger_view.cc @@ -101,7 +101,8 @@ void DebuggerView::OnInit() { web_contents_->render_view_host()->AllowDOMUIBindings(); GURL contents("chrome-resource://debugger/"); - web_contents_->controller()->LoadURL(contents, PageTransition::START_PAGE); + web_contents_->controller()->LoadURL(contents, GURL(), + PageTransition::START_PAGE); } void DebuggerView::OnShow() { @@ -123,9 +124,11 @@ void DebuggerView::SetDebuggerBreak(bool is_broken) { void DebuggerView::OpenURLFromTab(TabContents* source, const GURL& url, + const GURL& referrer, WindowOpenDisposition disposition, PageTransition::Type transition) { - BrowserList::GetLastActive()->OpenURL(url, disposition, transition); + BrowserList::GetLastActive()->OpenURL(url, referrer, disposition, + transition); } void DebuggerView::ExecuteJavascript(const std::string& js) { diff --git a/chrome/browser/debugger/debugger_view.h b/chrome/browser/debugger/debugger_view.h index e9e18e9..5a7f775 100644 --- a/chrome/browser/debugger/debugger_view.h +++ b/chrome/browser/debugger/debugger_view.h @@ -57,6 +57,7 @@ class DebuggerView : public views::View, // Overridden from PageNavigator (TabContentsDelegate's base interface): virtual void OpenURLFromTab(TabContents* source, const GURL& url, + const GURL& referrer, WindowOpenDisposition disposition, PageTransition::Type transition); |