diff options
author | maruel@google.com <maruel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-05 21:07:27 +0000 |
---|---|---|
committer | maruel@google.com <maruel@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-05 21:07:27 +0000 |
commit | d3216441b7726c31fb0ae9b9d90b64421e14ca39 (patch) | |
tree | 653882df34541ec7aa37e4024f8fce27fd9ba5b6 /chrome/browser/debugger | |
parent | ba61ace67a08e56026d2e8034d7a938d2f8e5bd6 (diff) | |
download | chromium_src-d3216441b7726c31fb0ae9b9d90b64421e14ca39.zip chromium_src-d3216441b7726c31fb0ae9b9d90b64421e14ca39.tar.gz chromium_src-d3216441b7726c31fb0ae9b9d90b64421e14ca39.tar.bz2 |
NO CODE CHANGE.
Split the lines >80 cols. (Part 1)
Review URL: http://codereview.chromium.org/39206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/debugger')
-rw-r--r-- | chrome/browser/debugger/debugger_io_socket.cc | 3 | ||||
-rw-r--r-- | chrome/browser/debugger/debugger_io_socket.h | 6 | ||||
-rw-r--r-- | chrome/browser/debugger/debugger_node.cc | 24 | ||||
-rw-r--r-- | chrome/browser/debugger/debugger_shell.cc | 18 |
4 files changed, 31 insertions, 20 deletions
diff --git a/chrome/browser/debugger/debugger_io_socket.cc b/chrome/browser/debugger/debugger_io_socket.cc index 30c5ac1..a7b857e 100644 --- a/chrome/browser/debugger/debugger_io_socket.cc +++ b/chrome/browser/debugger/debugger_io_socket.cc @@ -92,7 +92,8 @@ void DebuggerInputOutputSocket::OutputLater(const std::string& out, bool lf) { this, &DebuggerInputOutputSocket::OutputToSocket, out, lf)); } -void DebuggerInputOutputSocket::OutputToSocket(const std::string& out, bool lf) { +void DebuggerInputOutputSocket::OutputToSocket(const std::string& out, + bool lf) { DCHECK(MessageLoop::current() == io_loop_); if (connection_) { if (out.length()) { diff --git a/chrome/browser/debugger/debugger_io_socket.h b/chrome/browser/debugger/debugger_io_socket.h index 551e14d..ea7c522 100644 --- a/chrome/browser/debugger/debugger_io_socket.h +++ b/chrome/browser/debugger/debugger_io_socket.h @@ -12,9 +12,9 @@ class DebuggerHost; class MessageLoop; // Interaction with the underlying Socket object MUST happen in the IO thread. -// However, Debugger will call into this object from the main thread. As a result -// we wind up having helper methods that we call with InvokeLater into the IO -// thread. +// However, Debugger will call into this object from the main thread. As a +// result we wind up having helper methods that we call with InvokeLater into +// the IO thread. class DebuggerInputOutputSocket: public DebuggerInputOutput, public ListenSocket::ListenSocketDelegate { diff --git a/chrome/browser/debugger/debugger_node.cc b/chrome/browser/debugger/debugger_node.cc index 31374c6..2007575 100644 --- a/chrome/browser/debugger/debugger_node.cc +++ b/chrome/browser/debugger/debugger_node.cc @@ -69,12 +69,14 @@ v8::Handle<v8::Value> DebuggerNode::NewInstance() { } v8::Local<v8::ObjectTemplate> instance = templ->InstanceTemplate(); if (IsObject()) { - instance->SetNamedPropertyHandler(&DebuggerNode::NodeGetter, 0, 0, 0, 0, node); + instance->SetNamedPropertyHandler(&DebuggerNode::NodeGetter, 0, 0, 0, 0, + node); // TODO(erikkay): verify that the interceptor does not have to be // behind the object } if (IsCollection()) { - instance->SetIndexedPropertyHandler(&DebuggerNode::NodeIndex, 0, 0, 0, 0, node); + instance->SetIndexedPropertyHandler(&DebuggerNode::NodeIndex, 0, 0, 0, 0, + node); } v8::Local<v8::Object> ret = instance->NewInstance(); v8::Persistent<v8::Object> p = v8::Persistent<v8::Object>::New(ret); @@ -84,8 +86,8 @@ v8::Handle<v8::Value> DebuggerNode::NewInstance() { v8::Handle<v8::Value> DebuggerNode::NodeGetter(v8::Local<v8::String> prop, const v8::AccessorInfo& info) { - DebuggerNodeWrapper* w = - static_cast<DebuggerNodeWrapper*>(v8::External::Cast(*info.Data())->Value()); + DebuggerNodeWrapper* w = static_cast<DebuggerNodeWrapper*>(v8::External::Cast( + *info.Data())->Value()); DebuggerNode* n = w->node(); if (n->IsValid() && n->IsObject()) { return n->PropGetter(prop, info); @@ -96,8 +98,8 @@ v8::Handle<v8::Value> DebuggerNode::NodeGetter(v8::Local<v8::String> prop, v8::Handle<v8::Value> DebuggerNode::NodeIndex(uint32_t index, const v8::AccessorInfo& info) { - DebuggerNodeWrapper* w = - static_cast<DebuggerNodeWrapper*>(v8::External::Cast(*info.Data())->Value()); + DebuggerNodeWrapper* w = static_cast<DebuggerNodeWrapper*>(v8::External::Cast( + *info.Data())->Value()); DebuggerNode* n = w->node(); if (n->IsValid() && n->IsCollection()) { return n->IndexGetter(index, info); @@ -107,8 +109,8 @@ v8::Handle<v8::Value> DebuggerNode::NodeIndex(uint32_t index, } v8::Handle<v8::Value> DebuggerNode::NodeFunc(const v8::Arguments& args) { - DebuggerNodeWrapper* w = - static_cast<DebuggerNodeWrapper*>(v8::External::Cast(*args.Data())->Value()); + DebuggerNodeWrapper* w = static_cast<DebuggerNodeWrapper*>(v8::External::Cast( + *args.Data())->Value()); DebuggerNode* n = w->node(); if (n->IsValid() && n->IsFunction()) { return n->Function(args); @@ -137,11 +139,13 @@ v8::Handle<v8::Value> ChromeNode::PropGetter(v8::Handle<v8::String> prop, return node->NewInstance(); } else if (prop->Equals(v8::String::New("setDebuggerReady"))) { FunctionNode<DebuggerShell>* f = - new FunctionNode<DebuggerShell>(DebuggerShell::SetDebuggerReady, debugger_); + new FunctionNode<DebuggerShell>(DebuggerShell::SetDebuggerReady, + debugger_); return f->NewInstance(); } else if (prop->Equals(v8::String::New("setDebuggerBreak"))) { FunctionNode<DebuggerShell>* f = - new FunctionNode<DebuggerShell>(DebuggerShell::SetDebuggerBreak, debugger_); + new FunctionNode<DebuggerShell>(DebuggerShell::SetDebuggerBreak, + debugger_); return f->NewInstance(); } else if (prop->Equals(v8::String::New("foo"))) { return v8::Undefined(); diff --git a/chrome/browser/debugger/debugger_shell.cc b/chrome/browser/debugger/debugger_shell.cc index 7b1af30..65695a6 100644 --- a/chrome/browser/debugger/debugger_shell.cc +++ b/chrome/browser/debugger/debugger_shell.cc @@ -85,7 +85,8 @@ void DebuggerShell::Start() { CompileAndRun(debugger_shell_js, "chrome.dll/debugger_shell.js"); } -void DebuggerShell::HandleWeakReference(v8::Persistent<v8::Value> obj, void* data) { +void DebuggerShell::HandleWeakReference(v8::Persistent<v8::Value> obj, + void* data) { DebuggerNodeWrapper* node = static_cast<DebuggerNodeWrapper*>(data); node->Release(); } @@ -113,7 +114,8 @@ DebuggerInputOutput* DebuggerShell::GetIo() { return io_.get(); } -v8::Handle<v8::Value> DebuggerShell::DelegateSubshell(const v8::Arguments& args) { +v8::Handle<v8::Value> DebuggerShell::DelegateSubshell( + const v8::Arguments& args) { DebuggerShell* debugger = static_cast<DebuggerShell*>(v8::External::Cast(*args.Data())->Value()); return debugger->Subshell(args); @@ -136,7 +138,8 @@ v8::Handle<v8::Value> DebuggerShell::Subshell(const v8::Arguments& args) { v8_context_->Global()->Set(v8::String::New("shell_"), shell_); } } else if (args[0]->IsObject()) { - shell_ = v8::Persistent<v8::Object>::New(v8::Local<v8::Object>::Cast(args[0])); + shell_ = + v8::Persistent<v8::Object>::New(v8::Local<v8::Object>::Cast(args[0])); v8_context_->Global()->Set(v8::String::New("shell_"), shell_); } return v8::Undefined(); @@ -235,7 +238,8 @@ void DebuggerShell::DebugMessage(const std::wstring& msg) { v8::HandleScope scope; if (msg.length()) { - if ((msg[0] == L'{' || msg[0] == L'[' || msg[0] == L'(') && (!shell_.IsEmpty())) { + if ((msg[0] == L'{' || msg[0] == L'[' || msg[0] == L'(') && + (!shell_.IsEmpty())) { // v8's wide String constructor requires uint16 rather than wchar const uint16* data = reinterpret_cast<const uint16* >(msg.c_str()); v8::Handle<v8::Value> argv[] = {v8::String::New(data)}; @@ -262,7 +266,8 @@ void DebuggerShell::OnDebugDisconnect() { SubshellFunction("on_disconnect", 0, NULL); } -void DebuggerShell::ObjectToString(v8::Handle<v8::Value> result, std::wstring* str) { +void DebuggerShell::ObjectToString(v8::Handle<v8::Value> result, + std::wstring* str) { v8::HandleScope scope; if (!result.IsEmpty() && !result->IsUndefined()) { v8::Local<v8::String> str_obj = result->ToString(); @@ -277,7 +282,8 @@ void DebuggerShell::ObjectToString(v8::Handle<v8::Value> result, std::wstring* s } } -void DebuggerShell::ObjectToString(v8::Handle<v8::Value> result, std::string* str) { +void DebuggerShell::ObjectToString(v8::Handle<v8::Value> result, + std::string* str) { v8::HandleScope scope; if (!result.IsEmpty() && !result->IsUndefined()) { v8::Local<v8::String> str_obj = result->ToString(); |