Fix DeviceOrientationProviderTest.ObserverNotRemoved.

The problem was that some extra reference to Provider was left after the
ObserverNotRemoved test had finished. This reference was held by the
RunnableMethod object that executes ProviderImpl::DoInitializePollingThread on
a background thread. In the test, there were no guarantees that the body of
this function would finish before the test ended, thus causing a problem.

Fixing this by pushing another orientation through, forcing the Provider to
execute at least one Poll task on the background thread, which can only happen
after the initialization of the polling thread is done.

BUG=53865
TEST=unit_tests --gtest_filter=DeviceOrientationProviderTest.ObserverNotRemoved

Review URL: http://codereview.chromium.org/3232005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58359 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 4 insertions, 0 deletions

diff --git a/chrome/browser/device_orientation/provider_unittest.cc b/chrome/browser/device_orientation/provider_unittest.cc
index 60eedbc..a84de5bc 100644
--- a/chrome/browser/device_orientation/provider_unittest.cc
+++ b/chrome/browser/device_orientation/provider_unittest.cc
@@ -251,12 +251,16 @@ TEST_F(DeviceOrientationProviderTest, ObserverNotRemoved) {
       new MockOrientationFactory());
   Init(MockOrientationFactory::CreateDataFetcher);
   const Orientation kTestOrientation(true, 1, true, 2, true, 3);
+  const Orientation kTestOrientation2(true, 4, true, 5, true, 6);
 
   scoped_ptr<UpdateChecker> checker(new UpdateChecker(&pending_expectations_));
   checker->AddExpectation(kTestOrientation);
   orientation_factory->SetOrientation(kTestOrientation);
   provider_->AddObserver(checker.get());
+  MessageLoop::current()->Run();
 
+  checker->AddExpectation(kTestOrientation2);
+  orientation_factory->SetOrientation(kTestOrientation2);
   MessageLoop::current()->Run();
 
   // Note that checker is not removed. This should not be a problem.