diff options
| author | dgozman@chromium.org <dgozman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-19 14:51:10 +0000 |
|---|---|---|
| committer | dgozman@chromium.org <dgozman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-19 14:51:10 +0000 |
| commit | c429c2e7f15a7bf7db5fae54f23527ab5b71f886 (patch) | |
| tree | 8d1bac61b987856a75a82c932de357c634396011 /chrome/browser/devtools/devtools_window.cc | |
| parent | 7ee6660c04801595eb8d30e2f68c5f60b003d3a7 (diff) | |
| download | chromium_src-c429c2e7f15a7bf7db5fae54f23527ab5b71f886.zip chromium_src-c429c2e7f15a7bf7db5fae54f23527ab5b71f886.tar.gz chromium_src-c429c2e7f15a7bf7db5fae54f23527ab5b71f886.tar.bz2 | |
[DevTools] Pass inspected page bounds from frontend.
Passing bounds instead of insets is a more reliable approach in general, but has disadvantages when resizing the whole browser window (as new bounds are only available after round-trip to DevTools frontend).
BUG=373669
TBR=avi@chromium.org // For browser_window_controller_browsertest
Review URL: https://codereview.chromium.org/221283009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271379 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/devtools/devtools_window.cc')
| -rw-r--r-- | chrome/browser/devtools/devtools_window.cc | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc index bd7f2bd..a57699c 100644 --- a/chrome/browser/devtools/devtools_window.cc +++ b/chrome/browser/devtools/devtools_window.cc @@ -882,10 +882,18 @@ void DevToolsWindow::CloseWindow() { web_contents_->DispatchBeforeUnload(false); } -void DevToolsWindow::SetContentsInsets( - int top, int left, int bottom, int right) { - gfx::Insets insets(top, left, bottom, right); - SetContentsResizingStrategy(insets, contents_resizing_strategy_.min_size()); +void DevToolsWindow::SetInspectedPageBounds(const gfx::Rect& rect) { + DevToolsContentsResizingStrategy strategy(rect); + if (contents_resizing_strategy_.Equals(strategy)) + return; + + contents_resizing_strategy_.CopyFrom(strategy); + if (is_docked_) { + // Update inspected window. + BrowserWindow* inspected_window = GetInspectedBrowserWindow(); + if (inspected_window) + inspected_window->UpdateDevTools(); + } } void DevToolsWindow::SetContentsResizingStrategy( |