summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui/app_launcher_handler.cc
diff options
context:
space:
mode:
authoraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-29 00:35:01 +0000
committeraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-29 00:35:01 +0000
commit969894aba3265e77edafbc6556941ea693485cd8 (patch)
treee3906da6188b7831cfee8a60829989fa12ff2cd8 /chrome/browser/dom_ui/app_launcher_handler.cc
parentacc2f3cca43414cdcc46c0e9eefdb9002350c212 (diff)
downloadchromium_src-969894aba3265e77edafbc6556941ea693485cd8.zip
chromium_src-969894aba3265e77edafbc6556941ea693485cd8.tar.gz
chromium_src-969894aba3265e77edafbc6556941ea693485cd8.tar.bz2
Add the collapsed 'miniview' to the apps and most visisted sections. Also, fix the bug where the wrench disappears on hover.
BUG=53248,52199 Review URL: http://codereview.chromium.org/3236001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57799 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/dom_ui/app_launcher_handler.cc')
-rw-r--r--chrome/browser/dom_ui/app_launcher_handler.cc28
1 files changed, 16 insertions, 12 deletions
diff --git a/chrome/browser/dom_ui/app_launcher_handler.cc b/chrome/browser/dom_ui/app_launcher_handler.cc
index 1592528..2d3dee6 100644
--- a/chrome/browser/dom_ui/app_launcher_handler.cc
+++ b/chrome/browser/dom_ui/app_launcher_handler.cc
@@ -39,6 +39,15 @@ bool ExtractInt(const ListValue* list, size_t index, int* out_int) {
return false;
}
+std::string GetIconURL(Extension* extension, Extension::Icons icon,
+ const std::string& default_val) {
+ GURL url = extension->GetIconURL(icon);
+ if (!url.is_empty())
+ return url.spec();
+ else
+ return default_val;
+}
+
} // namespace
AppLauncherHandler::AppLauncherHandler(ExtensionsService* extension_service)
@@ -86,18 +95,13 @@ void AppLauncherHandler::CreateAppInfo(Extension* extension,
value->SetString("launch_url", extension->GetFullLaunchURL().spec());
value->SetString("options_url", extension->options_url().spec());
- FilePath relative_path =
- extension->GetIconResource(
- Extension::EXTENSION_ICON_LARGE).relative_path();
-
-#if defined(OS_POSIX)
- std::string path = relative_path.value();
-#elif defined(OS_WIN)
- std::string path = WideToUTF8(relative_path.value());
-#endif // OS_WIN
-
- GURL icon_url = extension->GetResourceURL(path);
- value->SetString("icon", icon_url.spec());
+ // TODO(aa): Need a better default icon for apps.
+ value->SetString("icon_big", GetIconURL(
+ extension, Extension::EXTENSION_ICON_LARGE,
+ "chrome://theme/IDR_EXTENSION_DEFAULT_ICON"));
+ value->SetString("icon_small", GetIconURL(
+ extension, Extension::EXTENSION_ICON_BITTY,
+ std::string("chrome://favicon/") + extension->GetFullLaunchURL().spec()));
}
void AppLauncherHandler::HandleGetApps(const ListValue* args) {