diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-23 23:52:57 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-23 23:52:57 +0000 |
| commit | 2fb62920c987513f7b5f041c99be5a8ed09888ec (patch) | |
| tree | 7c0355bb9fb4ecae13aeecc572a8261e94d89436 /chrome/browser/dom_ui/net_internals_ui.cc | |
| parent | 24d5cc6bb1328948d7a0658a7fa3acf6de5b91f8 (diff) | |
| download | chromium_src-2fb62920c987513f7b5f041c99be5a8ed09888ec.zip chromium_src-2fb62920c987513f7b5f041c99be5a8ed09888ec.tar.gz chromium_src-2fb62920c987513f7b5f041c99be5a8ed09888ec.tar.bz2 | |
Create a URLRequestContext for PAC fetching.
Originally I was going to create a single "system" URLRequestContext. I realized that was wrong, I need one for proxy script fetching that uses a direct ProxyService. This way, we don't have the circular dependencies for URLRequestContext(A)=>ProxyService=>ProxyScriptFetcherImpl=>URLRequestContext(A). Instead, we have URLRequestContext(A)=>ProxyService=>ProxyScriptFetcherImpl=>URLRequestContext(special one for proxy).
This also exposes some setters in URLRequestContext that were in ChromeURLRequestContext. I guess this makes URLRequestContext a bit more "dangerous" since it could be mutated during runtime, but really we should probably pass around a const URLRequestContext within the network stack. I've filed http://crbug.com/67597 to track this.
BUG=67232
TEST=none
Review URL: http://codereview.chromium.org/5961005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70116 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/dom_ui/net_internals_ui.cc')
| -rw-r--r-- | chrome/browser/dom_ui/net_internals_ui.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/dom_ui/net_internals_ui.cc b/chrome/browser/dom_ui/net_internals_ui.cc index f44ac9e..0cea72a 100644 --- a/chrome/browser/dom_ui/net_internals_ui.cc +++ b/chrome/browser/dom_ui/net_internals_ui.cc @@ -833,7 +833,8 @@ void NetInternalsMessageHandler::IOThreadImpl::OnStartConnectionTests( // For example, turn "www.google.com" into "http://www.google.com". GURL url(URLFixerUpper::FixupURL(UTF16ToUTF8(url_str), std::string())); - connection_tester_.reset(new ConnectionTester(this, io_thread_)); + connection_tester_.reset(new ConnectionTester( + this, io_thread_->globals()->proxy_script_fetcher_context.get())); connection_tester_->RunAllTests(url); } |