Take two for http://codereview.chromium.org/131094

This time without browser_tests timeout that caused the revert.  The problem was BrowsingHistoryHandler trying to use a dom_ui_ before being attached.

Review URL: http://codereview.chromium.org/149117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19556 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 5 deletions

diff --git a/chrome/browser/dom_ui/tips_handler.h b/chrome/browser/dom_ui/tips_handler.h
index 7847ba6..b6d5ccc 100644
--- a/chrome/browser/dom_ui/tips_handler.h
+++ b/chrome/browser/dom_ui/tips_handler.h
@@ -28,9 +28,12 @@ class Value;
 
 class TipsHandler : public DOMMessageHandler {
  public:
-  explicit TipsHandler(DOMUI* dom_ui);
+  TipsHandler() : tips_cache_(NULL) {}
+  virtual ~TipsHandler() {}
 
-  TipsHandler();
+  // DOMMessageHandler implementation and overrides. 
+  virtual DOMMessageHandler* Attach(DOMUI* dom_ui); 
+  virtual void RegisterMessages();
 
   // Callback which pulls tips data from the preferences.
   void HandleGetTips(const Value* content);
@@ -42,9 +45,6 @@ class TipsHandler : public DOMMessageHandler {
   // Make sure the string we are pushing to the NTP is a valid URL.
   bool IsValidURL(const std::wstring& url_string);
 
-  // So we can push data out to the page that has called this handler.
-  DOMUI* dom_ui_;
-
   // Filled with data from cache in preferences.
   const DictionaryValue* tips_cache_;