diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-07 16:48:07 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-07 16:48:07 +0000 |
| commit | 3ff3493b8904ee4db7b41cd1676ccdcb127ecbd8 (patch) | |
| tree | 6d3dcf4bf6a0f19d553a3e1a2c2eba0a81e72ce3 /chrome/browser/dom_ui | |
| parent | a64691f2882ea7403dc2fcd39f026583e12429fe (diff) | |
| download | chromium_src-3ff3493b8904ee4db7b41cd1676ccdcb127ecbd8.zip chromium_src-3ff3493b8904ee4db7b41cd1676ccdcb127ecbd8.tar.gz chromium_src-3ff3493b8904ee4db7b41cd1676ccdcb127ecbd8.tar.bz2 | |
Make the RenderViewHostFactory a global. This prevents us from having to pass
a factory pointer around all the time. Removing TestTabContents will require
making the Browser object keep track of the Factory pointer as well, so I think
the global is the best approach and cleans some things up.
Review URL: http://codereview.chromium.org/62044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13255 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/dom_ui')
| -rw-r--r-- | chrome/browser/dom_ui/dom_ui_host.cc | 1 | ||||
| -rw-r--r-- | chrome/browser/dom_ui/dom_ui_unittest.cc | 3 |
2 files changed, 1 insertions, 3 deletions
diff --git a/chrome/browser/dom_ui/dom_ui_host.cc b/chrome/browser/dom_ui/dom_ui_host.cc index ae7bcc40..ffeda1b 100644 --- a/chrome/browser/dom_ui/dom_ui_host.cc +++ b/chrome/browser/dom_ui/dom_ui_host.cc @@ -16,7 +16,6 @@ DOMUIHost::DOMUIHost(Profile* profile, RenderViewHostFactory* render_view_factory) : WebContents(profile, instance, - render_view_factory, MSG_ROUTING_NONE, NULL) { // Implementors of this class will have a specific tab contents type. diff --git a/chrome/browser/dom_ui/dom_ui_unittest.cc b/chrome/browser/dom_ui/dom_ui_unittest.cc index 3371acf..c1a554e 100644 --- a/chrome/browser/dom_ui/dom_ui_unittest.cc +++ b/chrome/browser/dom_ui/dom_ui_unittest.cc @@ -88,8 +88,7 @@ TEST_F(DOMUITest, DOMUIToStandard) { // slightly different than the very-first-navigation case since the // SiteInstance will be the same (the original WebContents must still be // alive), which will trigger different behavior in RenderViewHostManager. - WebContents* contents2 = new TestWebContents(profile_.get(), NULL, - &rvh_factory_); + WebContents* contents2 = new TestWebContents(profile_.get(), NULL); NavigationController* controller2 = new NavigationController(contents2, profile_.get()); contents2->set_controller(controller2); |