diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-29 21:29:26 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-29 21:29:26 +0000 |
| commit | ed0d9e421521daec1528febdb302dbb1b5f185dc (patch) | |
| tree | 9fae362f7c99fb45ad41d1bcc6b174bf1aa49281 /chrome/browser/dom_ui | |
| parent | 7a9b51f2274ba1732c5b80451346a4f2688365b5 (diff) | |
| download | chromium_src-ed0d9e421521daec1528febdb302dbb1b5f185dc.zip chromium_src-ed0d9e421521daec1528febdb302dbb1b5f185dc.tar.gz chromium_src-ed0d9e421521daec1528febdb302dbb1b5f185dc.tar.bz2 | |
Fix memory leak in tips handler.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/150052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19533 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/dom_ui')
| -rw-r--r-- | chrome/browser/dom_ui/tips_handler.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/dom_ui/tips_handler.cc b/chrome/browser/dom_ui/tips_handler.cc index a8ecd23..3d26945 100644 --- a/chrome/browser/dom_ui/tips_handler.cc +++ b/chrome/browser/dom_ui/tips_handler.cc @@ -57,12 +57,12 @@ void TipsHandler::HandleGetTips(const Value* content) { } else { int tip_counter = 0; while (tips_cache_->GetDictionary(IntToWString(tip_counter++), &wr_dict)) { - DictionaryValue* tip_dict = new DictionaryValue(); if (wr_dict && wr_dict->GetSize() > 0 && wr_dict->GetString(WebResourceService::kWebResourceTitle, &title) && wr_dict->GetString(WebResourceService::kWebResourceURL, &url) && IsValidURL(url)) { + DictionaryValue* tip_dict = new DictionaryValue(); tip_dict->SetString(WebResourceService::kWebResourceTitle, title); tip_dict->SetString(WebResourceService::kWebResourceURL, url); list_value.Append(tip_dict); |