summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui
diff options
context:
space:
mode:
authoraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-06 07:46:37 +0000
committeraa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-06 07:46:37 +0000
commit3e377c5a80be45d36a6015c80d9e2dae525cf042 (patch)
tree089f72c86a2f2314e527f2e95a3903253fbcf51a /chrome/browser/dom_ui
parenta42d22a1abe11d4f138c4c0870568be69bad5301 (diff)
downloadchromium_src-3e377c5a80be45d36a6015c80d9e2dae525cf042.zip
chromium_src-3e377c5a80be45d36a6015c80d9e2dae525cf042.tar.gz
chromium_src-3e377c5a80be45d36a6015c80d9e2dae525cf042.tar.bz2
Revert of r22559.
This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/dom_ui')
-rw-r--r--chrome/browser/dom_ui/dom_ui_favicon_source.cc2
-rw-r--r--chrome/browser/dom_ui/dom_ui_favicon_source.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/dom_ui/dom_ui_favicon_source.cc b/chrome/browser/dom_ui/dom_ui_favicon_source.cc
index 8f77134..bb7b9f0 100644
--- a/chrome/browser/dom_ui/dom_ui_favicon_source.cc
+++ b/chrome/browser/dom_ui/dom_ui_favicon_source.cc
@@ -42,7 +42,7 @@ void DOMUIFavIconSource::OnFavIconDataAvailable(
bool know_favicon,
scoped_refptr<RefCountedBytes> data,
bool expired,
- const GURL& icon_url) {
+ GURL icon_url) {
HistoryService* hs =
profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
int request_id = cancelable_consumer_.GetClientData(hs, request_handle);
diff --git a/chrome/browser/dom_ui/dom_ui_favicon_source.h b/chrome/browser/dom_ui/dom_ui_favicon_source.h
index b33f0e5..42d770c 100644
--- a/chrome/browser/dom_ui/dom_ui_favicon_source.h
+++ b/chrome/browser/dom_ui/dom_ui_favicon_source.h
@@ -37,7 +37,7 @@ class DOMUIFavIconSource : public ChromeURLDataManager::DataSource {
bool know_favicon,
scoped_refptr<RefCountedBytes> data,
bool expired,
- const GURL& url);
+ GURL url);
private:
Profile* profile_;