summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui
diff options
context:
space:
mode:
authorphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-13 10:29:07 +0000
committerphajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-13 10:29:07 +0000
commit5c2387504ee4124ce0521212d895bae87cf08d8f (patch)
tree3e9c3539afbd5cb96af547a012fd99ad4f1aecac /chrome/browser/dom_ui
parent94fe52ee5bdf2d2feaa771537164909250ec174f (diff)
downloadchromium_src-5c2387504ee4124ce0521212d895bae87cf08d8f.zip
chromium_src-5c2387504ee4124ce0521212d895bae87cf08d8f.tar.gz
chromium_src-5c2387504ee4124ce0521212d895bae87cf08d8f.tar.bz2
Reduce header dependencies in browser/
- remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/dom_ui')
-rw-r--r--chrome/browser/dom_ui/debugger_ui.cc2
-rw-r--r--chrome/browser/dom_ui/dom_ui.h1
-rw-r--r--chrome/browser/dom_ui/downloads_dom_handler.cc3
-rw-r--r--chrome/browser/dom_ui/downloads_dom_handler.h4
-rw-r--r--chrome/browser/dom_ui/html_dialog_ui.h5
5 files changed, 11 insertions, 4 deletions
diff --git a/chrome/browser/dom_ui/debugger_ui.cc b/chrome/browser/dom_ui/debugger_ui.cc
index 7467571..fd29146 100644
--- a/chrome/browser/dom_ui/debugger_ui.cc
+++ b/chrome/browser/dom_ui/debugger_ui.cc
@@ -7,7 +7,9 @@
#include "app/resource_bundle.h"
#include "base/command_line.h"
#include "base/file_util.h"
+#include "base/message_loop.h"
#include "base/string_util.h"
+#include "base/thread.h"
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/debugger/debugger_shell.h"
diff --git a/chrome/browser/dom_ui/dom_ui.h b/chrome/browser/dom_ui/dom_ui.h
index fadff05..553ab28 100644
--- a/chrome/browser/dom_ui/dom_ui.h
+++ b/chrome/browser/dom_ui/dom_ui.h
@@ -12,7 +12,6 @@
#include "base/string16.h"
#include "base/task.h"
#include "chrome/common/page_transition_types.h"
-#include "webkit/glue/window_open_disposition.h"
class DictionaryValue;
class DOMMessageHandler;
diff --git a/chrome/browser/dom_ui/downloads_dom_handler.cc b/chrome/browser/dom_ui/downloads_dom_handler.cc
index 1f2c217..3a5388c 100644
--- a/chrome/browser/dom_ui/downloads_dom_handler.cc
+++ b/chrome/browser/dom_ui/downloads_dom_handler.cc
@@ -10,6 +10,7 @@
#include "base/string_piece.h"
#include "base/thread.h"
#include "base/time_format.h"
+#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/dom_ui/chrome_url_data_manager.h"
#include "chrome/browser/dom_ui/fileicon_source.h"
@@ -340,7 +341,7 @@ std::wstring DownloadsDOMHandler::GetProgressStatusText(
time_remaining = TimeFormat::TimeRemaining(remaining);
if (time_remaining.empty()) {
- return l10n_util::GetStringF(IDS_DOWNLOAD_TAB_PROGRESS_STATUS_TIME_UNKNOWN,
+ return l10n_util::GetStringF(IDS_DOWNLOAD_TAB_PROGRESS_STATUS_TIME_UNKNOWN,
speed_text, amount);
}
return l10n_util::GetStringF(IDS_DOWNLOAD_TAB_PROGRESS_STATUS, speed_text,
diff --git a/chrome/browser/dom_ui/downloads_dom_handler.h b/chrome/browser/dom_ui/downloads_dom_handler.h
index d8e6501..729960c 100644
--- a/chrome/browser/dom_ui/downloads_dom_handler.h
+++ b/chrome/browser/dom_ui/downloads_dom_handler.h
@@ -7,10 +7,12 @@
#include <vector>
-#include "base/values.h"
#include "chrome/browser/dom_ui/dom_ui.h"
#include "chrome/browser/download/download_manager.h"
+class DictionaryValue;
+class Value;
+
// The handler for Javascript messages related to the "downloads" view,
// also observes changes to the download manager.
class DownloadsDOMHandler : public DOMMessageHandler,
diff --git a/chrome/browser/dom_ui/html_dialog_ui.h b/chrome/browser/dom_ui/html_dialog_ui.h
index 29895d2..76240cd 100644
--- a/chrome/browser/dom_ui/html_dialog_ui.h
+++ b/chrome/browser/dom_ui/html_dialog_ui.h
@@ -5,11 +5,14 @@
#ifndef CHROME_BROWSER_DOM_UI_HTML_DIALOG_UI_H_
#define CHROME_BROWSER_DOM_UI_HTML_DIALOG_UI_H_
-#include "base/gfx/size.h"
#include "chrome/browser/dom_ui/dom_ui.h"
#include "chrome/common/property_bag.h"
#include "googleurl/src/gurl.h"
+namespace gfx {
+class Size;
+}
+
// Implement this class to receive notifications.
class HtmlDialogUIDelegate {
public: