diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-29 00:27:43 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-29 00:27:43 +0000 |
| commit | e7f83b5b31528d5e405f6d163b30834674ee36f2 (patch) | |
| tree | 88444708f3199793acbb67e98516f90fa765c653 /chrome/browser/dom_ui | |
| parent | ac4e28f7846406caa715467b806d3f2a6f4417d1 (diff) | |
| download | chromium_src-e7f83b5b31528d5e405f6d163b30834674ee36f2.zip chromium_src-e7f83b5b31528d5e405f6d163b30834674ee36f2.tar.gz chromium_src-e7f83b5b31528d5e405f6d163b30834674ee36f2.tar.bz2 | |
Fix memory leaks in unit tests from my previous checkin.
BUG=25354
Review URL: http://codereview.chromium.org/348003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30410 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/dom_ui')
| -rw-r--r-- | chrome/browser/dom_ui/new_tab_ui.cc | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/chrome/browser/dom_ui/new_tab_ui.cc b/chrome/browser/dom_ui/new_tab_ui.cc index 6d34031..5f50603 100644 --- a/chrome/browser/dom_ui/new_tab_ui.cc +++ b/chrome/browser/dom_ui/new_tab_ui.cc @@ -572,12 +572,14 @@ NewTabUI::NewTabUI(TabContents* contents) InitializeCSSCaches(); NewTabHTMLSource* html_source = new NewTabHTMLSource(GetProfile()); - ChromeThread::PostTask( + bool posted = ChromeThread::PostTask( ChromeThread::IO, FROM_HERE, NewRunnableMethod( &chrome_url_data_manager, &ChromeURLDataManager::AddDataSource, html_source)); + if (!posted) + delete html_source; // Keep Valgrind happy in tests. } // Listen for theme installation. @@ -614,12 +616,15 @@ void NewTabUI::Observe(NotificationType type, } void NewTabUI::InitializeCSSCaches() { - ChromeThread::PostTask( + DOMUIThemeSource* theme = new DOMUIThemeSource(GetProfile()); + bool posted = ChromeThread::PostTask( ChromeThread::IO, FROM_HERE, NewRunnableMethod( &chrome_url_data_manager, &ChromeURLDataManager::AddDataSource, - new DOMUIThemeSource(GetProfile()))); + theme)); + if (!posted) + delete theme; // Keep Valgrind happy in tests. } // static |