diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-27 16:27:15 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-27 16:27:15 +0000 |
| commit | f15edeb24bd34ef09d6c62b734eca5765f5c2854 (patch) | |
| tree | 24d4ef0375b0aab1486fb52d0ae9fa41766b262d /chrome/browser/download/save_file_manager.cc | |
| parent | a0eca45b109d89137269cb9b5004e8a51309a6b2 (diff) | |
| download | chromium_src-f15edeb24bd34ef09d6c62b734eca5765f5c2854.zip chromium_src-f15edeb24bd34ef09d6c62b734eca5765f5c2854.tar.gz chromium_src-f15edeb24bd34ef09d6c62b734eca5765f5c2854.tar.bz2 | |
Download code cleanup: share most of the code between DownloadFile and SaveFile.
I'm not really happy about BaseFile, but removing the remaining differences
will require changes to DownloadFileManager and SaveFileManager.
I prefer to do that in small steps.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3164039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57688 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/download/save_file_manager.cc')
| -rw-r--r-- | chrome/browser/download/save_file_manager.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/chrome/browser/download/save_file_manager.cc b/chrome/browser/download/save_file_manager.cc index f106d6a..00e9251 100644 --- a/chrome/browser/download/save_file_manager.cc +++ b/chrome/browser/download/save_file_manager.cc @@ -220,6 +220,10 @@ void SaveFileManager::StartSave(SaveFileCreateInfo* info) { DCHECK(ChromeThread::CurrentlyOn(ChromeThread::FILE)); DCHECK(info); SaveFile* save_file = new SaveFile(info); + + // TODO(phajdan.jr): We should check the return value and handle errors here. + save_file->Initialize(); + DCHECK(!LookupSaveFile(info->save_id)); save_file_map_[info->save_id] = save_file; info->path = save_file->full_path(); @@ -486,7 +490,7 @@ void SaveFileManager::RenameAllFiles( if (it != save_file_map_.end()) { SaveFile* save_file = it->second; DCHECK(!save_file->in_progress()); - save_file->Rename(i->second); + save_file->Rename(i->second, true); delete save_file; save_file_map_.erase(it); } |