diff options
| author | pinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-22 20:38:33 +0000 |
|---|---|---|
| committer | pinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-22 20:38:33 +0000 |
| commit | 7e920a366d0e24f17fd10063ea18dbe71eb9d914 (patch) | |
| tree | 4dd50c80f168d12679de1535a34f31cd19327e27 /chrome/browser/download/save_page_uitest.cc | |
| parent | d807bf963f1960566263b20de2997bd74ebca1a6 (diff) | |
| download | chromium_src-7e920a366d0e24f17fd10063ea18dbe71eb9d914.zip chromium_src-7e920a366d0e24f17fd10063ea18dbe71eb9d914.tar.gz chromium_src-7e920a366d0e24f17fd10063ea18dbe71eb9d914.tar.bz2 | |
Enable more tests, change a NOTREACHED to a bug since it's not fatal in the download code. Get other tests compiling even if disabled. Mark why tests are failing in gyp file.
Review URL: http://codereview.chromium.org/92033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14239 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/download/save_page_uitest.cc')
| -rw-r--r-- | chrome/browser/download/save_page_uitest.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chrome/browser/download/save_page_uitest.cc b/chrome/browser/download/save_page_uitest.cc index ecb15e8..bac6b86 100644 --- a/chrome/browser/download/save_page_uitest.cc +++ b/chrome/browser/download/save_page_uitest.cc @@ -22,8 +22,8 @@ const std::string kTestDir = "save_page"; const std::string kAppendedExtension = ".htm"; #elif defined(OS_LINUX) const std::string kAppendedExtension = ""; -#elif defined(OS_MAC) -// TODO(port): figure this out for mac. +#elif defined(OS_MACOSX) +const std::string kAppendedExtension = ".html"; #endif class SavePageTest : public UITest { @@ -169,8 +169,8 @@ TEST_F(SavePageTest, FilenameFromPageTitle) { } // This tests that a webpage with the title "test.exe" is saved as "test.htm". -// We probably don't care to handle this on linux. -#if !defined(OS_LINUX) +// We probably don't care to handle this on Linux or Mac. +#if defined(OS_WIN) TEST_F(SavePageTest, CleanFilenameFromPageTitle) { std::string file_name = "c.htm"; FilePath full_file_name = download_dir_.AppendASCII("test" + |