summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
diff options
context:
space:
mode:
authorjcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-17 19:57:24 +0000
committerjcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-17 19:57:24 +0000
commit7cef64b495701e8ff17b2fbb6e632aa34eee450f (patch)
tree8af439034838b28edd0223010a1f6aad4b2f61ce /chrome/browser/download
parenta16d22388edff186095e37fecd5537beae88c7c9 (diff)
downloadchromium_src-7cef64b495701e8ff17b2fbb6e632aa34eee450f.zip
chromium_src-7cef64b495701e8ff17b2fbb6e632aa34eee450f.tar.gz
chromium_src-7cef64b495701e8ff17b2fbb6e632aa34eee450f.tar.bz2
Reverting 7149.
Review URL: http://codereview.chromium.org/15004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7153 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/download')
-rw-r--r--chrome/browser/download/download_file.cc6
-rw-r--r--chrome/browser/download/download_manager.cc4
-rw-r--r--chrome/browser/download/download_request_manager.cc6
-rw-r--r--chrome/browser/download/save_file_manager.cc10
4 files changed, 15 insertions, 11 deletions
diff --git a/chrome/browser/download/download_file.cc b/chrome/browser/download/download_file.cc
index 2a5e612..f921661 100644
--- a/chrome/browser/download/download_file.cc
+++ b/chrome/browser/download/download_file.cc
@@ -16,8 +16,8 @@
#include "chrome/browser/download/download_manager.h"
#include "chrome/browser/profile.h"
#include "chrome/browser/resource_dispatcher_host.h"
+#include "chrome/browser/tab_contents.h"
#include "chrome/browser/tab_util.h"
-#include "chrome/browser/web_contents.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/stl_util-inl.h"
#include "chrome/common/win_util.h"
@@ -458,9 +458,9 @@ void DownloadFileManager::RemoveDownload(int id, DownloadManager* manager) {
// static
DownloadManager* DownloadFileManager::DownloadManagerFromRenderIds(
int render_process_id, int render_view_id) {
- WebContents* contents = tab_util::GetWebContentsByID(render_process_id,
+ TabContents* contents = tab_util::GetTabContentsByID(render_process_id,
render_view_id);
- if (contents) {
+ if (contents && contents->type() == TAB_CONTENTS_WEB) {
Profile* profile = contents->profile();
if (profile)
return profile->GetDownloadManager();
diff --git a/chrome/browser/download/download_manager.cc b/chrome/browser/download/download_manager.cc
index adf62d3..5328807 100644
--- a/chrome/browser/download/download_manager.cc
+++ b/chrome/browser/download/download_manager.cc
@@ -618,7 +618,7 @@ void DownloadManager::OnPathExistenceAvailable(DownloadCreateInfo* info) {
if (!select_file_dialog_.get())
select_file_dialog_ = SelectFileDialog::Create(this);
- WebContents* contents = tab_util::GetWebContentsByID(
+ TabContents* contents = tab_util::GetTabContentsByID(
info->render_process_id, info->render_view_id);
std::wstring filter = win_util::GetFileFilterFromPath(info->suggested_path);
HWND owning_hwnd =
@@ -1308,7 +1308,7 @@ void DownloadManager::OnCreateDownloadEntryComplete(DownloadCreateInfo info,
// this start completion event. If it does, tell the origin WebContents to
// display its download shelf.
TabContents* contents =
- tab_util::GetWebContentsByID(info.render_process_id, info.render_view_id);
+ tab_util::GetTabContentsByID(info.render_process_id, info.render_view_id);
// If the contents no longer exists or is no longer active, we start the
// download in the last active browser. This is not ideal but better than
diff --git a/chrome/browser/download/download_request_manager.cc b/chrome/browser/download/download_request_manager.cc
index ac4cdb5..6869d6e 100644
--- a/chrome/browser/download/download_request_manager.cc
+++ b/chrome/browser/download/download_request_manager.cc
@@ -9,9 +9,9 @@
#include "chrome/browser/navigation_controller.h"
#include "chrome/browser/navigation_entry.h"
#include "chrome/browser/constrained_window.h"
+#include "chrome/browser/tab_contents.h"
#include "chrome/browser/tab_contents_delegate.h"
#include "chrome/browser/tab_util.h"
-#include "chrome/browser/web_contents.h"
#include "chrome/common/l10n_util.h"
#include "chrome/common/notification_registrar.h"
#include "chrome/common/notification_service.h"
@@ -409,8 +409,8 @@ void DownloadRequestManager::CanDownload(int render_process_host_id,
Callback* callback) {
DCHECK(!ui_loop_ || MessageLoop::current() == ui_loop_);
- WebContents* originating_tab =
- tab_util::GetWebContentsByID(render_process_host_id, render_view_id);
+ TabContents* originating_tab =
+ tab_util::GetTabContentsByID(render_process_host_id, render_view_id);
if (!originating_tab) {
// The tab was closed, don't allow the download.
ScheduleNotification(callback, false);
diff --git a/chrome/browser/download/save_file_manager.cc b/chrome/browser/download/save_file_manager.cc
index 631b55d..940e878 100644
--- a/chrome/browser/download/save_file_manager.cc
+++ b/chrome/browser/download/save_file_manager.cc
@@ -215,10 +215,14 @@ void SaveFileManager::RemoveSaveFile(int save_id, const std::wstring& save_url,
// only on the UI thread.
SavePackage* SaveFileManager::GetSavePackageFromRenderIds(
int render_process_id, int render_view_id) {
- WebContents* contents = tab_util::GetWebContentsByID(render_process_id,
+ TabContents* contents = tab_util::GetTabContentsByID(render_process_id,
render_view_id);
- if (contents)
- return contents->save_package();
+ if (contents && contents->type() == TAB_CONTENTS_WEB) {
+ // Convert const pointer of WebContents to pointer of WebContents.
+ const WebContents* web_contents = contents->AsWebContents();
+ if (web_contents)
+ return web_contents->save_package();
+ }
return NULL;
}