diff options
| author | varunjain@chromium.org <varunjain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-28 15:57:01 +0000 |
|---|---|---|
| committer | varunjain@chromium.org <varunjain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-28 15:57:01 +0000 |
| commit | 81e164014774429ab0d0eec0e7807b4814377e5d (patch) | |
| tree | db0315f56a62d9bde425fafac52662c818692749 /chrome/browser/download | |
| parent | 8e8df0e0d5f0720dbd57275aaabd206b6900369b (diff) | |
| download | chromium_src-81e164014774429ab0d0eec0e7807b4814377e5d.zip chromium_src-81e164014774429ab0d0eec0e7807b4814377e5d.tar.gz chromium_src-81e164014774429ab0d0eec0e7807b4814377e5d.tar.bz2 | |
Check for null widget in DragDownload which is causing the crash in the bug.
BUG=120430
TEST=none
Review URL: http://codereview.chromium.org/9791024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129417 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/download')
| -rw-r--r-- | chrome/browser/download/download_util.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc index ef25a03..d1eb22a 100644 --- a/chrome/browser/download/download_util.cc +++ b/chrome/browser/download/download_util.cc @@ -398,6 +398,11 @@ void DragDownload(const DownloadItem* download, #if !defined(TOOLKIT_USES_GTK) views::Widget* widget = views::Widget::GetWidgetForNativeView(view); + // TODO(varunjain): Widget should not be NULL here. But its causing the crash + // in http://code.google.com/p/chromium/issues/detail?id=120430 Find out why. + if (!widget || !widget->native_widget()) + return; + gfx::Point location = gfx::Screen::GetCursorScreenPoint(); // We do not care about notifying the DragItemView on completion of drag. So // we pass NULL to RunShellDrag for the source view. |