Fix sorting downloads on chrome://downloads.

BUG=151756


Review URL: https://chromiumcodereview.appspot.com/10978023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158922 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 7 insertions, 1 deletions

diff --git a/chrome/browser/download/download_query.cc b/chrome/browser/download/download_query.cc
index cd2d439..0a458db 100644
--- a/chrome/browser/download/download_query.cc
+++ b/chrome/browser/download/download_query.cc
@@ -79,6 +79,12 @@ static bool MatchesQuery(const string16& query, const DownloadItem& item) {
       query, path, NULL, NULL);
 }
 
+static int64 GetStartTimeMsEpoch(const DownloadItem& item) {
+  return (item.GetStartTime() - base::Time::UnixEpoch()).InMilliseconds();
+}
+
+// TODO(benjhayden) These timestamps don't fit in int32, and base::Value doesn't
+// support int64. Use ISO 8601 date-time strings instead.
 static int GetStartTime(const DownloadItem& item) {
   return (item.GetStartTime() - base::Time::UnixEpoch()).InMilliseconds();
 }
@@ -342,7 +348,7 @@ void DownloadQuery::AddSorter(DownloadQuery::SortType type,
                               DownloadQuery::SortDirection direction) {
   switch (type) {
     case SORT_START_TIME:
-      sorters_.push_back(Sorter::Build<int>(direction, &GetStartTime));
+      sorters_.push_back(Sorter::Build<int64>(direction, &GetStartTimeMsEpoch));
       break;
     case SORT_URL:
       sorters_.push_back(Sorter::Build<std::string>(direction, &GetUrl));