diff options
| author | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-28 20:50:12 +0000 |
|---|---|---|
| committer | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-28 20:50:12 +0000 |
| commit | aeab57ea8560065d6c513fcd46bb43e1bfbfd7a6 (patch) | |
| tree | a63f2d36e86361d5c27122a6d6ef4098b755d7d9 /chrome/browser/download_tab_view.h | |
| parent | e115558691eb08608fad56bb32f40265fdfa4ac5 (diff) | |
| download | chromium_src-aeab57ea8560065d6c513fcd46bb43e1bfbfd7a6.zip chromium_src-aeab57ea8560065d6c513fcd46bb43e1bfbfd7a6.tar.gz chromium_src-aeab57ea8560065d6c513fcd46bb43e1bfbfd7a6.tar.bz2 | |
Simplify OneShotTimer and RepeatingTimer. Fix up all consumers.
Major changes:
OneShotTimer and RepeatingTimer become template classes that no longer require
a Task or a Timer object. They just use PostDelayedTask. Under the hood that
still uses a Timer object.
The API is much simpler for consumers as they now no longer need to worry about
allocating a Task or managing the lifetime of the object pointer held by the
Task.
I added some new unit tests to timer_unittest.cc to cover the API.
I preserved the old TimerManager / Timer API for now, but I plan to soon kill
it.
R=brettw
BUG=1346553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1502 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/download_tab_view.h')
| -rw-r--r-- | chrome/browser/download_tab_view.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/browser/download_tab_view.h b/chrome/browser/download_tab_view.h index 59eebe5..346a903 100644 --- a/chrome/browser/download_tab_view.h +++ b/chrome/browser/download_tab_view.h @@ -21,7 +21,10 @@ class DownloadTabView; class SkBitmap; class Task; + +namespace base { class Timer; +} class DownloadItemTabView : public ChromeViews::View, public ChromeViews::LinkController { @@ -170,7 +173,7 @@ class DownloadTabView : public ChromeViews::View, OrderedDownloads downloads_; // Progress animations - Timer* progress_timer_; + base::Timer* progress_timer_; Task* progress_task_; // Since this view manages the progress animation timers for all the floating |