diff options
| author | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-18 21:44:44 +0000 |
|---|---|---|
| committer | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-18 21:44:44 +0000 |
| commit | 5a1ad5c1ba4c5b9e86805e1c6fb7364492d6ac80 (patch) | |
| tree | 471ff33ec7c19913601fc03dfaf63de606c21022 /chrome/browser/extensions/app_notification.h | |
| parent | 0b5781a63246fb4abf31f871b445a6d85970b19f (diff) | |
| download | chromium_src-5a1ad5c1ba4c5b9e86805e1c6fb7364492d6ac80.zip chromium_src-5a1ad5c1ba4c5b9e86805e1c6fb7364492d6ac80.tar.gz chromium_src-5a1ad5c1ba4c5b9e86805e1c6fb7364492d6ac80.tar.bz2 | |
Revert 106110 - Implement SyncableService in AppNotificationsManager:
- Implement all methods of SyncableService
- Modify existing methods that change the model (Add and ClearAll) to push changes to sync.
- Add some extra properties to AppNotification: guid and extension id
- Disallow operations on model until storage is loaded.
- Ton of unit tests for sync methods
There is anotehr part for the full notifications sync to work that will be done in a separate CL.
Review URL: http://codereview.chromium.org/8263002
TBR=munjal@chromium.org
Review URL: http://codereview.chromium.org/8345022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106136 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/app_notification.h')
| -rw-r--r-- | chrome/browser/extensions/app_notification.h | 18 |
1 files changed, 1 insertions, 17 deletions
diff --git a/chrome/browser/extensions/app_notification.h b/chrome/browser/extensions/app_notification.h index 4a9deb6..8fd7743 100644 --- a/chrome/browser/extensions/app_notification.h +++ b/chrome/browser/extensions/app_notification.h @@ -17,14 +17,7 @@ // displayed on the New Tab Page. class AppNotification { public: - // Creates an instance with the given properties. - // If |is_local| is true, notification is not synced. - // If |guid| is empty, a new guid is automatically created. - AppNotification(bool is_local, - const std::string& guid, - const std::string& extension_id, - const std::string& title, - const std::string& body); + AppNotification(const std::string& title, const std::string& body); ~AppNotification(); // Setters for optional properties. @@ -32,9 +25,6 @@ class AppNotification { void set_link_text(const std::string& text) { link_text_ = text; } // Accessors. - bool is_local() const { return is_local_; } - const std::string& guid() const { return guid_; } - const std::string& extension_id() const { return extension_id_; } const std::string& title() const { return title_; } const std::string& body() const { return body_; } const GURL& link_url() const { return link_url_; } @@ -51,12 +41,6 @@ class AppNotification { // If you add to the list of data members, make sure to add appropriate checks // to the Equals and {To,From}DictionaryValue methods, keeping in mind // backwards compatibility. - - // Whether notification is local only, which means it is not synced - // across machines. - bool is_local_; - std::string guid_; - std::string extension_id_; std::string title_; std::string body_; GURL link_url_; |