PageActions now work across tabs and windows.

The extension system now provides TabId to extensions so it is now possible to activate PageActions in other tabs besides the first in the tab strip. :)

BUG=None
TEST=None (requires a PageAction extension to test against).

Review URL: http://codereview.chromium.org/109046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15415 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 7 deletions

diff --git a/chrome/browser/extensions/extension.h b/chrome/browser/extensions/extension.h
index bf62694..c612203 100644
--- a/chrome/browser/extensions/extension.h
+++ b/chrome/browser/extensions/extension.h
@@ -128,9 +128,8 @@ class Extension {
   // as providing a theme.
   FilePath GetThemeResourcePath(const int resource_id);
 
-  // Update the status of the page action with |id| in tab |tab_id| and set the
-  // current page url to |url|.
-  bool UpdatePageAction(std::string id, int tab_id, GURL url);
+  // Retrieves a page action by |id|.
+  const PageAction* GetPageAction(std::string id) const;
 
   const FilePath& path() const { return path_; }
   const GURL& url() const { return extension_url_; }
@@ -158,10 +157,9 @@ class Extension {
 
   // Helper method that loads a PageAction object from a
   // dictionary in the page_action list of the manifest.
-  bool LoadPageActionHelper(const DictionaryValue* page_action,
-                            int definition_index,
-                            std::string* error,
-                            PageAction* result);
+  PageAction* LoadPageActionHelper(const DictionaryValue* page_action,
+                                   int definition_index,
+                                   std::string* error);
 
   // The absolute path to the directory the extension is stored in.
   FilePath path_;