diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 17:45:16 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 17:45:16 +0000 |
| commit | c290a6237ec644fc77c9328c0756be76b8316be8 (patch) | |
| tree | 3c4dc9ff93706c806f7fdafd4dc37278aff020c6 /chrome/browser/extensions/extension_apitest.cc | |
| parent | 1549593d29cb99d623d2c81bb83a5f01f60f7f0f (diff) | |
| download | chromium_src-c290a6237ec644fc77c9328c0756be76b8316be8.zip chromium_src-c290a6237ec644fc77c9328c0756be76b8316be8.tar.gz chromium_src-c290a6237ec644fc77c9328c0756be76b8316be8.tar.bz2 | |
ExtensionApiTest improvements.
This fixes a race condition where ExtensionBrowserTest::WaitForExtensionHostsToLoad() could have exited before all hosts were loaded. It simplifies the Overrides test. It also adds some debug output for aiding the hunt for remaining flakiness.
BUG=22668
Review URL: http://codereview.chromium.org/220039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27213 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_apitest.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_apitest.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc index 415d1c9..0a8875d 100644 --- a/chrome/browser/extensions/extension_apitest.cc +++ b/chrome/browser/extensions/extension_apitest.cc @@ -14,7 +14,10 @@ static const int kTimeoutMs = 60 * 1000; // 1 minute // Load an extension and wait for it to notify of PASSED or FAILED. bool ExtensionApiTest::RunExtensionTest(const char* extension_name) { + // Note the inner scope here. The |registrar| will fall out of scope and + // remove listeners *before* the call to WaitForPassFail() below. { + LOG(INFO) << "Running ExtensionApiTest with: " << extension_name; NotificationRegistrar registrar; registrar.Add(this, NotificationType::EXTENSION_TEST_PASSED, NotificationService::AllSources()); |