summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_cookies_api.cc
diff options
context:
space:
mode:
authorrdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-27 17:25:38 +0000
committerrdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-08-27 17:25:38 +0000
commitc58030205f55b793ec6cedbaa1967ccc4a9f3465 (patch)
tree165cadae761d963560a4c55a510d9c637390ad29 /chrome/browser/extensions/extension_cookies_api.cc
parent001774129509b18784637bb8569cf9b090388797 (diff)
downloadchromium_src-c58030205f55b793ec6cedbaa1967ccc4a9f3465.zip
chromium_src-c58030205f55b793ec6cedbaa1967ccc4a9f3465.tar.gz
chromium_src-c58030205f55b793ec6cedbaa1967ccc4a9f3465.tar.bz2
Change, unify, and specify ordering of cookies from CookieMonster.
Affected interfaces: * GetCookiesWithOptions (used by HTTP requests) * GetAllCookiesForURL (used by extensions and Cookies UI) * GetAllCookies (used by Cookies UI). BUG=8850 (indirectly) TEST=Standard cookie monster tests, unit_tests::CookiesTreeModelTest.OriginOrdering, browser_tests::ExtensionApiTest.Cookies Review URL: http://codereview.chromium.org/3170034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57694 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_cookies_api.cc')
-rw-r--r--chrome/browser/extensions/extension_cookies_api.cc3
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/extensions/extension_cookies_api.cc b/chrome/browser/extensions/extension_cookies_api.cc
index afb9c12..f50d475 100644
--- a/chrome/browser/extensions/extension_cookies_api.cc
+++ b/chrome/browser/extensions/extension_cookies_api.cc
@@ -191,7 +191,8 @@ void GetCookieFunction::RespondOnUIThread() {
net::CookieMonster::CookieList::iterator it;
for (it = cookie_list_.begin(); it != cookie_list_.end(); ++it) {
// Return the first matching cookie. Relies on the fact that the
- // CookieMonster retrieves them in reverse domain-length order.
+ // CookieMonster returns them in canonical order (longest path, then
+ // earliest creation time).
if (it->Name() == name_) {
result_.reset(
extension_cookies_helpers::CreateCookieValue(*it, store_id_));