diff options
author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-24 19:59:41 +0000 |
---|---|---|
committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-24 19:59:41 +0000 |
commit | 0ec9203dac6b11c664adda8a39b77f3f00eb6072 (patch) | |
tree | 65e5cff3f9e04da87e32e9436ddc795a7811c278 /chrome/browser/extensions/extension_dom_ui.h | |
parent | 630d1b047c8c4ea54eef06fa24a89ad516457875 (diff) | |
download | chromium_src-0ec9203dac6b11c664adda8a39b77f3f00eb6072.zip chromium_src-0ec9203dac6b11c664adda8a39b77f3f00eb6072.tar.gz chromium_src-0ec9203dac6b11c664adda8a39b77f3f00eb6072.tar.bz2 |
Generalize the ExtensionFunctionDispatcher::Delegate interface a bit more. In particular remove GetExtensionHost() and GetExtensionDOMUI(). I'm going to add a new type of EFD::Delegate soon that is neither of these, and I don't think it makes sense to have the code assume that EFD::Delegate must be one of the two of them.
Some code still does RTTI stuff through RenderViewHostDelegate::GetRenderViewType(), but in that case it is more clear that there are a long list of potential view types, and that the caller must be more careful.
Review URL: http://codereview.chromium.org/1149003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42519 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_dom_ui.h')
-rw-r--r-- | chrome/browser/extensions/extension_dom_ui.h | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/chrome/browser/extensions/extension_dom_ui.h b/chrome/browser/extensions/extension_dom_ui.h index 54de39c..7892b89 100644 --- a/chrome/browser/extensions/extension_dom_ui.h +++ b/chrome/browser/extensions/extension_dom_ui.h @@ -41,13 +41,11 @@ class ExtensionDOMUI bool has_callback); // ExtensionFunctionDispatcher::Delegate - virtual Browser* GetBrowser(bool include_incognito) const; - virtual ExtensionDOMUI* GetExtensionDOMUI() { return this; } - virtual gfx::NativeWindow GetFrameNativeWindow(); + virtual Browser* GetBrowser() const; + virtual gfx::NativeView GetNativeViewOfHost(); + virtual gfx::NativeWindow GetCustomFrameNativeWindow(); - virtual RenderViewHost* GetRenderViewHost(); virtual Profile* GetProfile(); - virtual gfx::NativeView GetNativeViewOfHost(); virtual ExtensionBookmarkManagerEventRouter* extension_bookmark_manager_event_router() { |