diff options
| author | kalman@chromium.org <kalman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-04 10:45:30 +0000 |
|---|---|---|
| committer | kalman@chromium.org <kalman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-04 10:45:30 +0000 |
| commit | 73a85e0183de62b1a18212b852775c1845a0c9cf (patch) | |
| tree | 9784c8c8f869ee8fc6602d9fcf2beb95e2af9d53 /chrome/browser/extensions/extension_error_ui.h | |
| parent | 0234e3d9d4c6f64777ef0935fe7b071d105b89b5 (diff) | |
| download | chromium_src-73a85e0183de62b1a18212b852775c1845a0c9cf.zip chromium_src-73a85e0183de62b1a18212b852775c1845a0c9cf.tar.gz chromium_src-73a85e0183de62b1a18212b852775c1845a0c9cf.tar.bz2 | |
Fix a null dereference in ExtensionService::HandleExtensionAlertAccept by closing
the active alert via the UI object rather than calling ExtensionService's event
handler directly.
BUG=224281
Review URL: https://chromiumcodereview.appspot.com/13440003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192278 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_error_ui.h')
| -rw-r--r-- | chrome/browser/extensions/extension_error_ui.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/chrome/browser/extensions/extension_error_ui.h b/chrome/browser/extensions/extension_error_ui.h index 9aedbd2..63714b2 100644 --- a/chrome/browser/extensions/extension_error_ui.h +++ b/chrome/browser/extensions/extension_error_ui.h @@ -46,6 +46,10 @@ class ExtensionErrorUI { // It should use the same browser as where the bubble was shown. virtual void ShowExtensions() = 0; + // Closes the error UI. This will end up calling BubbleViewDidClose, possibly + // synchronously. + virtual void Close() = 0; + protected: explicit ExtensionErrorUI(ExtensionService* extension_service); @@ -59,7 +63,7 @@ class ExtensionErrorUI { // Sub-classes should call this methods based on the actions taken by the user // in the error bubble. - void BubbleViewDidClose(); + void BubbleViewDidClose(); // destroys |this| void BubbleViewAcceptButtonPressed(); void BubbleViewCancelButtonPressed(); |