Fixes to the string MatchPattern functions:

1) Make it explicit that it only supports ASCII (since it iterates
character by character).
2) Limit the recursion to 16 levels.  We could allow more, but in the
case of a ?, it has exponential complexity, so I figured 16 was a good
stopping point.  It seems rare that someone would have more than 16
'?' and '*'s.

BUG=28645

Review URL: http://codereview.chromium.org/460047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33748 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 2 deletions

diff --git a/chrome/browser/extensions/extension_file_util_unittest.cc b/chrome/browser/extensions/extension_file_util_unittest.cc
index 6e00eb0..4184272 100644
--- a/chrome/browser/extensions/extension_file_util_unittest.cc
+++ b/chrome/browser/extensions/extension_file_util_unittest.cc
@@ -233,7 +233,7 @@ TEST(ExtensionFileUtil, MissingPrivacyBlacklist) {
       extension_file_util::LoadExtension(install_dir, false, &error));
   ASSERT_TRUE(extension == NULL);
   ASSERT_FALSE(error.empty());
-  EXPECT_TRUE(MatchPattern(error,
+  EXPECT_TRUE(MatchPatternASCII(error,
       "Could not load '*privacy_blacklist.pbl' for privacy blacklist: "
       "file does not exist.")) << error;
 }
@@ -250,7 +250,7 @@ TEST(ExtensionFileUtil, InvalidPrivacyBlacklist) {
       extension_file_util::LoadExtension(install_dir, false, &error));
   ASSERT_TRUE(extension == NULL);
   ASSERT_FALSE(error.empty());
-  EXPECT_TRUE(MatchPattern(error,
+  EXPECT_TRUE(MatchPatternASCII(error,
       "Could not load '*privacy_blacklist.pbl' for privacy blacklist: "
       "Incorrect header.")) << error;
 }