summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_file_util_unittest.cc
diff options
context:
space:
mode:
authorestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-12-18 02:39:16 +0000
committerestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-12-18 02:39:16 +0000
commit99efb7b19b5ecb8e7f8f3b646f191fda8a756841 (patch)
tree3d569055ca0cfa7a1af56e3226c89927117006b8 /chrome/browser/extensions/extension_file_util_unittest.cc
parent4bd50cba12dc8311d3913569c3d43aa64f7312d0 (diff)
downloadchromium_src-99efb7b19b5ecb8e7f8f3b646f191fda8a756841.zip
chromium_src-99efb7b19b5ecb8e7f8f3b646f191fda8a756841.tar.gz
chromium_src-99efb7b19b5ecb8e7f8f3b646f191fda8a756841.tar.bz2
Extensions: file handling clean up.
- remove various invalid uses of ASCII functions - properly escape resource requests - clean up file path handling Some work remains to be done on the last bullet point but this is enough to fix the bug. BUG=30509 TEST=see bug Review URL: http://codereview.chromium.org/501046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34923 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_file_util_unittest.cc')
-rw-r--r--chrome/browser/extensions/extension_file_util_unittest.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/extensions/extension_file_util_unittest.cc b/chrome/browser/extensions/extension_file_util_unittest.cc
index 5b6cd71..675914d 100644
--- a/chrome/browser/extensions/extension_file_util_unittest.cc
+++ b/chrome/browser/extensions/extension_file_util_unittest.cc
@@ -162,7 +162,7 @@ TEST(ExtensionFileUtil, CheckIllegalFilenamesOnlyReserved) {
ScopedTempDir temp;
ASSERT_TRUE(temp.CreateUniqueTempDir());
- FilePath src_path = temp.path().AppendASCII(Extension::kLocaleFolder);
+ FilePath src_path = temp.path().Append(Extension::kLocaleFolder);
ASSERT_TRUE(file_util::CreateDirectory(src_path));
std::string error;
@@ -174,7 +174,7 @@ TEST(ExtensionFileUtil, CheckIllegalFilenamesReservedAndIllegal) {
ScopedTempDir temp;
ASSERT_TRUE(temp.CreateUniqueTempDir());
- FilePath src_path = temp.path().AppendASCII(Extension::kLocaleFolder);
+ FilePath src_path = temp.path().Append(Extension::kLocaleFolder);
ASSERT_TRUE(file_util::CreateDirectory(src_path));
src_path = temp.path().AppendASCII("_some_dir");