summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_function.cc
diff options
context:
space:
mode:
authorvabr@chromium.org <vabr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-07 21:46:36 +0000
committervabr@chromium.org <vabr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-07 21:46:36 +0000
commit7cb19b4202a97cc3cc6b88d7c9d58ea5885d5cf3 (patch)
tree5bd0c5643882c84e1af0148af62d82b9435fd51b /chrome/browser/extensions/extension_function.cc
parent7054e78fe6a2fcda72b06dc196b5f91cfdc75872 (diff)
downloadchromium_src-7cb19b4202a97cc3cc6b88d7c9d58ea5885d5cf3.zip
chromium_src-7cb19b4202a97cc3cc6b88d7c9d58ea5885d5cf3.tar.gz
chromium_src-7cb19b4202a97cc3cc6b88d7c9d58ea5885d5cf3.tar.bz2
Revert CL 10358002 (return NOTREACHED())
Reverting http://codereview.chromium.org/10358002/ by returning NOTREACHED() into the "bad-message" handler in chrome/browser/extensions/extension_function.cc. This is a consequence of a discussion with Bernhard, logged in http://codereview.chromium.org/10358002/. BUG=115467 Review URL: http://codereview.chromium.org/10386008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135732 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_function.cc')
-rw-r--r--chrome/browser/extensions/extension_function.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/extensions/extension_function.cc b/chrome/browser/extensions/extension_function.cc
index 6f77fa8..e21ff3b 100644
--- a/chrome/browser/extensions/extension_function.cc
+++ b/chrome/browser/extensions/extension_function.cc
@@ -145,6 +145,7 @@ void ExtensionFunction::HandleBadMessage(base::ProcessHandle process) {
// In single process mode it is better if we don't suicide but just crash.
CHECK(false);
} else {
+ NOTREACHED();
content::RecordAction(UserMetricsAction("BadMessageTerminate_EFD"));
if (process)
base::KillProcess(process, content::RESULT_CODE_KILLED_BAD_MESSAGE,