diff options
| author | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-20 02:48:01 +0000 |
|---|---|---|
| committer | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-20 02:48:01 +0000 |
| commit | 602542d6a7ea6313321d9badfe232df3daf12cef (patch) | |
| tree | cda79b0ce15174a989df6925f891b3d23036f9d5 /chrome/browser/extensions/extension_function_dispatcher.cc | |
| parent | 415fe1d7c0dc7c06aaae7840c4d42d8120420fcf (diff) | |
| download | chromium_src-602542d6a7ea6313321d9badfe232df3daf12cef.zip chromium_src-602542d6a7ea6313321d9badfe232df3daf12cef.tar.gz chromium_src-602542d6a7ea6313321d9badfe232df3daf12cef.tar.bz2 | |
Use Value objects instead of JSON strings in extension API response IPCs.
When we're sending the result of an extension API method call, we currently
convert a Value object into a JSON string in the browser process, and then call
JSON.parse in javascript on the renderer side. This CL changes that to pass the
Value object in the IPC, and uses V8ValueConverter to turn the Value into the
appropriate v8 native object, avoiding the need to parse JSON.
This is a first step towards supporting binary data for API request
parameters and responses.
BUG=122675
TEST=No new functionality ; existing unit and browser tests should still pass.
Review URL: https://chromiumcodereview.appspot.com/10041047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133133 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_function_dispatcher.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_function_dispatcher.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc index 588d088..78aa9d7 100644 --- a/chrome/browser/extensions/extension_function_dispatcher.cc +++ b/chrome/browser/extensions/extension_function_dispatcher.cc @@ -303,7 +303,8 @@ ExtensionFunction* ExtensionFunctionDispatcher::CreateExtensionFunction( // static void ExtensionFunctionDispatcher::SendAccessDenied( IPC::Message::Sender* ipc_sender, int routing_id, int request_id) { + ListValue empty_list; ipc_sender->Send(new ExtensionMsg_Response( - routing_id, request_id, false, std::string(), + routing_id, request_id, false, empty_list, "Access to extension API denied.")); } |