diff options
author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-17 18:20:31 +0000 |
---|---|---|
committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-17 18:20:31 +0000 |
commit | 01f829ab3cc802b79942f5a988f6a72e7a2b594d (patch) | |
tree | 8d5566ebfa133239e7947cac02b685df95d5b66f /chrome/browser/extensions/extension_function_dispatcher.cc | |
parent | 5715c63e814adcf7d0515ea08c16955d49615a33 (diff) | |
download | chromium_src-01f829ab3cc802b79942f5a988f6a72e7a2b594d.zip chromium_src-01f829ab3cc802b79942f5a988f6a72e7a2b594d.tar.gz chromium_src-01f829ab3cc802b79942f5a988f6a72e7a2b594d.tar.bz2 |
Initial support for inspecting extension popups.
The primary change in this CL is a refactor which makes ExtensionPopup a bit more self-contained WRT its clients. It adds the ability to specify an "inspect_with_devtools" flag to its Show() method which will cause the popup to remain open regardless of losing focus and to focus a devtools window on the popup's render view host.
This CL also pulls apart some aspects of the extension_popup_api from ExtensionFunctionDispatcher and ExtensionHost.
Still remaining to be done are:
1) Also the popup to stay open when the host window drags (it current closes)
2) Support for GTK
3) Support for Mac
BUG=24477
Review URL: http://codereview.chromium.org/1001002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41854 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_function_dispatcher.cc')
-rw-r--r-- | chrome/browser/extensions/extension_function_dispatcher.cc | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc index 1e6bee1..640725d 100644 --- a/chrome/browser/extensions/extension_function_dispatcher.cc +++ b/chrome/browser/extensions/extension_function_dispatcher.cc @@ -321,18 +321,6 @@ Browser* ExtensionFunctionDispatcher::GetBrowser(bool include_incognito) { return delegate_->GetBrowser(include_incognito); } -ExtensionPopupHost* ExtensionFunctionDispatcher::GetPopupHost() { - ExtensionHost* extension_host = GetExtensionHost(); - if (extension_host) { - DCHECK(!GetExtensionDOMUI()) << - "Function dispatcher registered in too many environments."; - return extension_host->popup_host(); - } else { - ExtensionDOMUI* dom_ui = GetExtensionDOMUI(); - return dom_ui->popup_host(); - } -} - ExtensionHost* ExtensionFunctionDispatcher::GetExtensionHost() { return delegate_->GetExtensionHost(); } |