diff options
author | mtytel@chromium.org <mtytel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-12 22:39:09 +0000 |
---|---|---|
committer | mtytel@chromium.org <mtytel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-12 22:39:09 +0000 |
commit | 07ff5fdb0c27afeed02cec68d42c49c4d694d521 (patch) | |
tree | 9c616ed2d25f1284716fd193999943fb24ae4cb2 /chrome/browser/extensions/extension_function_test_utils.cc | |
parent | b8da3c2d5cb4399505bd3e8cd05a00c588c1e45f (diff) | |
download | chromium_src-07ff5fdb0c27afeed02cec68d42c49c4d694d521.zip chromium_src-07ff5fdb0c27afeed02cec68d42c49c4d694d521.tar.gz chromium_src-07ff5fdb0c27afeed02cec68d42c49c4d694d521.tar.bz2 |
Added support for multiple parameters to Extension API callbacks.
BUG=135269
TEST=
Review URL: https://chromiumcodereview.appspot.com/10694106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146469 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_function_test_utils.cc')
-rw-r--r-- | chrome/browser/extensions/extension_function_test_utils.cc | 28 |
1 files changed, 17 insertions, 11 deletions
diff --git a/chrome/browser/extensions/extension_function_test_utils.cc b/chrome/browser/extensions/extension_function_test_utils.cc index 2f0fc46..29097ec 100644 --- a/chrome/browser/extensions/extension_function_test_utils.cc +++ b/chrome/browser/extensions/extension_function_test_utils.cc @@ -130,25 +130,31 @@ std::string RunFunctionAndReturnError(UIThreadExtensionFunction* function, RunFunctionFlags flags) { scoped_refptr<ExtensionFunction> function_owner(function); RunFunction(function, args, browser, flags); - EXPECT_FALSE(function->GetResultValue()) << "Did not expect a result"; + EXPECT_FALSE(function->GetResultList()) << "Did not expect a result"; return function->GetError(); } -base::Value* RunFunctionAndReturnResult(UIThreadExtensionFunction* function, - const std::string& args, - Browser* browser) { - return RunFunctionAndReturnResult(function, args, browser, NONE); +base::Value* RunFunctionAndReturnSingleResult( + UIThreadExtensionFunction* function, + const std::string& args, + Browser* browser) { + return RunFunctionAndReturnSingleResult(function, args, browser, NONE); } -base::Value* RunFunctionAndReturnResult(UIThreadExtensionFunction* function, - const std::string& args, - Browser* browser, - RunFunctionFlags flags) { +base::Value* RunFunctionAndReturnSingleResult( + UIThreadExtensionFunction* function, + const std::string& args, + Browser* browser, + RunFunctionFlags flags) { scoped_refptr<ExtensionFunction> function_owner(function); RunFunction(function, args, browser, flags); EXPECT_TRUE(function->GetError().empty()) << "Unexpected error: " << function->GetError(); - return (function->GetResultValue() == NULL) ? NULL : - function->GetResultValue()->DeepCopy(); + base::Value* single_result = NULL; + if (function->GetResultList() != NULL && + function->GetResultList()->Get(0, &single_result)) { + return single_result->DeepCopy(); + } + return NULL; } // This helps us be able to wait until an AsyncExtensionFunction calls |