diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-20 21:17:48 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-20 21:17:48 +0000 |
| commit | 72400a8010a0aa614a42fa8e2f3ae826b209ded0 (patch) | |
| tree | 930185ac2cb658d311406df45b6178db0e029b9c /chrome/browser/extensions/extension_function_test_utils.cc | |
| parent | f41fc935bce54d4c4f5417323ec4d8eec775e399 (diff) | |
| download | chromium_src-72400a8010a0aa614a42fa8e2f3ae826b209ded0.zip chromium_src-72400a8010a0aa614a42fa8e2f3ae826b209ded0.tar.gz chromium_src-72400a8010a0aa614a42fa8e2f3ae826b209ded0.tar.bz2 | |
Remove broken variables from sync's AllStatus
* syncer_stuck: This value would get set if we failed to make progress
in resolving conflict sets. The conflict set processing code is never
executed (crbug.com/107816). I suspect there were other problems with
this status indicator, but this alone is enough to justify its removal.
* server_broken: Because the number of commits was never greater than
25, there's no way we could see >100 commits bounce because of a
transient error in a single sync cycle. This value is always false.
* disk_full: Never set. Always false.
* CONFLICT status summary value: It depends on syncer_stuck.
* HandleAuthWatcherEvent(): This method was undefined.
This is not the full set of AllStatus fixes. There are some other
status indicators that should be removed, but I wanted to limit the
scope of this commit to removing broken indicators. Mostly useless but
still functional indicators will be removed in future commits.
BUG=98346,105739
TEST=
Review URL: http://codereview.chromium.org/9149017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118499 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_function_test_utils.cc')
0 files changed, 0 insertions, 0 deletions