diff options
| author | thiago.santos <thiago.santos@intel.com> | 2015-01-05 12:20:58 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-05 20:22:34 +0000 |
| commit | 08f751fc5809acdc575897552bc1e4a806a6896e (patch) | |
| tree | 944558d702bb39840911160875132e698eaa2d93 /chrome/browser/extensions/extension_function_test_utils.h | |
| parent | 680387d2cb867f892a4adbac5ac0c355cda851ba (diff) | |
| download | chromium_src-08f751fc5809acdc575897552bc1e4a806a6896e.zip chromium_src-08f751fc5809acdc575897552bc1e4a806a6896e.tar.gz chromium_src-08f751fc5809acdc575897552bc1e4a806a6896e.tar.bz2 | |
Removed duplicated code in extension_function_test_utils
Removed few functions from extension_function_test_utils that were
already being forwarded to api_test_utils and updated the tests using
them.
Review URL: https://codereview.chromium.org/825723002
Cr-Commit-Position: refs/heads/master@{#309951}
Diffstat (limited to 'chrome/browser/extensions/extension_function_test_utils.h')
| -rw-r--r-- | chrome/browser/extensions/extension_function_test_utils.h | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/chrome/browser/extensions/extension_function_test_utils.h b/chrome/browser/extensions/extension_function_test_utils.h index aa340e4..3c10c61 100644 --- a/chrome/browser/extensions/extension_function_test_utils.h +++ b/chrome/browser/extensions/extension_function_test_utils.h @@ -33,14 +33,6 @@ namespace extension_function_test_utils { // or not the specified type. base::Value* ParseJSON(const std::string& data); base::ListValue* ParseList(const std::string& data); -base::DictionaryValue* ParseDictionary(const std::string& data); - -// Get |key| from |val| as the specified type. If |key| does not exist, or is -// not of the specified type, adds a failure to the current test and returns -// false, 0, empty string, etc. -bool GetBoolean(const base::DictionaryValue* val, const std::string& key); -int GetInteger(const base::DictionaryValue* val, const std::string& key); -std::string GetString(const base::DictionaryValue* val, const std::string& key); // If |val| is a dictionary, return it as one, otherwise NULL. base::DictionaryValue* ToDictionary(base::Value* val); @@ -53,16 +45,6 @@ base::ListValue* ToList(base::Value* val); scoped_refptr<extensions::Extension> CreateEmptyExtensionWithLocation( extensions::Manifest::Location location); -scoped_refptr<extensions::Extension> CreateExtension( - extensions::Manifest::Location location, - base::DictionaryValue* test_extension_value, - const std::string& id_input); - -// Creates an extension instance with a specified extension value that can be -// attached to an ExtensionFunction before running. -scoped_refptr<extensions::Extension> CreateExtension( - base::DictionaryValue* test_extension_value); - // Returns true if |val| contains privacy information, e.g. url, // title, and faviconUrl. bool HasPrivacySensitiveFields(base::DictionaryValue* val); |