diff options
| author | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-09 21:02:37 +0000 |
|---|---|---|
| committer | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-09 21:02:37 +0000 |
| commit | f8636f9eb80eded0371d8011b1921e2871aa7c6b (patch) | |
| tree | 7d086d71475dce0563f607e9748ddbf49125ace0 /chrome/browser/extensions/extension_functional_browsertest.cc | |
| parent | a8e53e4f053a38dc8e4bf8771f6b51bfb3ea42d9 (diff) | |
| download | chromium_src-f8636f9eb80eded0371d8011b1921e2871aa7c6b.zip chromium_src-f8636f9eb80eded0371d8011b1921e2871aa7c6b.tar.gz chromium_src-f8636f9eb80eded0371d8011b1921e2871aa7c6b.tar.bz2 | |
Make CrxInstaller creation take install prompt as a scoped_ptr
This helps to clarify that callers are passing ownership of the
ExtensionInstallPrompt that they pass in. Doing this turned up some cases
in crx_installer_browsertest.cc where we were accessing the raw pointer to
the MockInstallPrompt after handing off ownership of it, so this also
introduces a MockPromptProxy class to save the information we need in tests
but avoids holding on to a possibly invalid pointer.
BUG=269049
TBR=phajdan.jr,benjhayden,pkasting,joaodasilva,bauerb (for mechanical changes in various files)
Review URL: https://chromiumcodereview.appspot.com/22272005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216749 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_functional_browsertest.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_functional_browsertest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/extensions/extension_functional_browsertest.cc b/chrome/browser/extensions/extension_functional_browsertest.cc index 25ceba5..38a8650 100644 --- a/chrome/browser/extensions/extension_functional_browsertest.cc +++ b/chrome/browser/extensions/extension_functional_browsertest.cc @@ -27,7 +27,7 @@ public: content::NotificationService::AllSources()); scoped_refptr<extensions::CrxInstaller> installer( - extensions::CrxInstaller::Create(service, NULL)); + extensions::CrxInstaller::CreateSilent(service)); installer->set_is_gallery_install(false); installer->set_allow_silent_install(true); installer->set_install_source(Manifest::INTERNAL); |