diff options
author | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-16 05:52:23 +0000 |
---|---|---|
committer | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-16 05:52:23 +0000 |
commit | 4eabd06ab6f594ee7244be72efb03b51e778d478 (patch) | |
tree | dcc81e49cf857343014e39a813ada7b1995c8570 /chrome/browser/extensions/extension_host_mac.h | |
parent | f86f596f260b883a4763437a49926bc483cea071 (diff) | |
download | chromium_src-4eabd06ab6f594ee7244be72efb03b51e778d478.zip chromium_src-4eabd06ab6f594ee7244be72efb03b51e778d478.tar.gz chromium_src-4eabd06ab6f594ee7244be72efb03b51e778d478.tar.bz2 |
Have ExtensionHost use TabContents instead of RenderViewHost. Try #2.
The first landing broke popups on the Mac. Specifically, the auto-resizing of TabContents interfered with how ExtensionViewMac tried to resize itself, causing an infinite feedback loop. Also, we need to defer updating the size of the container until the ExtensionHost is loaded so that we don't display an empty window.
BUG=84146
TEST=extensions still work
Review URL: http://codereview.chromium.org/8498022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110262 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_host_mac.h')
-rw-r--r-- | chrome/browser/extensions/extension_host_mac.h | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/chrome/browser/extensions/extension_host_mac.h b/chrome/browser/extensions/extension_host_mac.h index d688f9f4..2425d82 100644 --- a/chrome/browser/extensions/extension_host_mac.h +++ b/chrome/browser/extensions/extension_host_mac.h @@ -10,18 +10,14 @@ class RenderWidgetHostView; +// TODO(mpcomplete): I don't know what this does or if it is needed anymore, +// now that ExtensionHost is restructured to rely on TabContents. class ExtensionHostMac : public ExtensionHost { public: ExtensionHostMac(const Extension* extension, SiteInstance* site_instance, const GURL& url, content::ViewType host_type) : ExtensionHost(extension, site_instance, url, host_type) {} virtual ~ExtensionHostMac(); - protected: - virtual RenderWidgetHostView* CreateNewWidgetInternal( - int route_id, - WebKit::WebPopupType popup_type); - virtual void ShowCreatedWidgetInternal(RenderWidgetHostView* widget_host_view, - const gfx::Rect& initial_pos); private: virtual void UnhandledKeyboardEvent(const NativeWebKeyboardEvent& event); |