Implement first cut at the extension installation prompt on Windows.

Had to move set_path() earlier in the unpack process so that we would have real paths for the resources, so that we could load and display the icon in the ui.

This exposed a problem where page actions had absolute paths and other images in extensions had relative paths. Extension::GetBrowserImages() was expecting relative paths, and it just happened to work because in both cases Extension was initialized without a path.

Modified page actions to use relative paths to be consistent with other images.

Review URL: http://codereview.chromium.org/160516

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22368 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 4 deletions

diff --git a/chrome/browser/extensions/extension_install_ui.h b/chrome/browser/extensions/extension_install_ui.h
index 1fc0379..9cdc5ac 100644
--- a/chrome/browser/extensions/extension_install_ui.h
+++ b/chrome/browser/extensions/extension_install_ui.h
@@ -16,16 +16,20 @@ class Profile;
 class SandboxedExtensionUnpacker;
 
 // Displays all the UI around extension installation.
-//
-// TODO(aa): This will become a view and move to browser/views/extensions in the
-// future.
 class ExtensionInstallUI : public CrxInstallerClient {
  public:
+  // NOTE: The implementation of this is platform-specific.
+  static void ShowExtensionInstallPrompt(Profile* profile,
+                                         CrxInstaller* installer,
+                                         Extension* extension,
+                                         SkBitmap* install_icon);
+
   ExtensionInstallUI(Profile* profile);
 
  private:
   // CrxInstallerClient
-  virtual bool ConfirmInstall(Extension* extension);
+  virtual void ConfirmInstall(CrxInstaller* installer, Extension* extension,
+                              SkBitmap* icon);
   virtual void OnInstallSuccess(Extension* extension);
   virtual void OnInstallFailure(const std::string& error);
   virtual void OnOverinstallAttempted(Extension* extension);