diff options
author | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-02 20:42:26 +0000 |
---|---|---|
committer | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-02 20:42:26 +0000 |
commit | b9eea12850008f465aaa2d20ab84a2b0b5be9671 (patch) | |
tree | 9b813444e9e7bac7f5c3e0c7b8ce47716fd53fd9 /chrome/browser/extensions/extension_message_service.h | |
parent | 87638af779ecfa2358090671234a3f239db47d37 (diff) | |
download | chromium_src-b9eea12850008f465aaa2d20ab84a2b0b5be9671.zip chromium_src-b9eea12850008f465aaa2d20ab84a2b0b5be9671.tar.gz chromium_src-b9eea12850008f465aaa2d20ab84a2b0b5be9671.tar.bz2 |
Fix some issues with extension messaging:
- Disconnect ports properly (javascript mistake).
- Use the right port ID when dispatching the disconnect event.
- Fix a bug with 2 extensions loaded in the same process.
BUG=12686
BUG=15798
TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting.
Review URL: http://codereview.chromium.org/152003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19844 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_message_service.h')
-rw-r--r-- | chrome/browser/extensions/extension_message_service.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/browser/extensions/extension_message_service.h b/chrome/browser/extensions/extension_message_service.h index f128103..e3b7ba8 100644 --- a/chrome/browser/extensions/extension_message_service.h +++ b/chrome/browser/extensions/extension_message_service.h @@ -140,13 +140,15 @@ class ExtensionMessageService : public NotificationObserver { // opened. void OpenChannelOnUIThread(int source_routing_id, int source_port_id, int source_process_id, - int dest_port_id, int dest_process_id); + int dest_port_id, int dest_process_id, + const std::string& extension_id); // Common between OpenChannelOnUIThread and // OpenAutomationChannelToExtension. void OpenChannelOnUIThreadImpl( - int source_routing_id, int source_port_id, IPC::Message::Sender* source, - int dest_port_id, int dest_process_id, int source_process_id); + int source_routing_id, int source_port_id, int source_process_id, + IPC::Message::Sender* source, int dest_port_id, int dest_process_id, + const std::string& extension_id); MessageChannelMap channels_; |