diff options
| author | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-02 20:42:26 +0000 |
|---|---|---|
| committer | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-02 20:42:26 +0000 |
| commit | b9eea12850008f465aaa2d20ab84a2b0b5be9671 (patch) | |
| tree | 9b813444e9e7bac7f5c3e0c7b8ce47716fd53fd9 /chrome/browser/extensions/extension_messages_unittest.cc | |
| parent | 87638af779ecfa2358090671234a3f239db47d37 (diff) | |
| download | chromium_src-b9eea12850008f465aaa2d20ab84a2b0b5be9671.zip chromium_src-b9eea12850008f465aaa2d20ab84a2b0b5be9671.tar.gz chromium_src-b9eea12850008f465aaa2d20ab84a2b0b5be9671.tar.bz2 | |
Fix some issues with extension messaging:
- Disconnect ports properly (javascript mistake).
- Use the right port ID when dispatching the disconnect event.
- Fix a bug with 2 extensions loaded in the same process.
BUG=12686
BUG=15798
TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting.
Review URL: http://codereview.chromium.org/152003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19844 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_messages_unittest.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_messages_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/extensions/extension_messages_unittest.cc b/chrome/browser/extensions/extension_messages_unittest.cc index 45de6c7..86a3180 100644 --- a/chrome/browser/extensions/extension_messages_unittest.cc +++ b/chrome/browser/extensions/extension_messages_unittest.cc @@ -34,7 +34,7 @@ static void DispatchOnMessage(const std::string& message, int source_port_id) { // Tests that the bindings for opening a channel to an extension and sending // and receiving messages through that channel all works. -TEST_F(RenderViewTest, DISABLED_ExtensionMessagesOpenChannel) { +TEST_F(RenderViewTest, ExtensionMessagesOpenChannel) { render_thread_.sink().ClearMessages(); LoadHTML("<body></body>"); ExecuteJavaScript( @@ -78,7 +78,7 @@ TEST_F(RenderViewTest, DISABLED_ExtensionMessagesOpenChannel) { // Tests that the bindings for handling a new channel connection and channel // closing all works. -TEST_F(RenderViewTest, DISABLED_ExtensionMessagesOnConnect) { +TEST_F(RenderViewTest, ExtensionMessagesOnConnect) { LoadHTML("<body></body>"); ExecuteJavaScript( "chrome.self.onConnect.addListener(function (port) {" |