diff options
author | mpcomplete@google.com <mpcomplete@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-01 21:17:49 +0000 |
---|---|---|
committer | mpcomplete@google.com <mpcomplete@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-01 21:17:49 +0000 |
commit | 4b5d64ff3d7d95247ed4f078d8bf585a1726794d (patch) | |
tree | 050a523a5bbccf28ade0814b38bcc9bee187cd04 /chrome/browser/extensions/extension_messages_unittest.cc | |
parent | 912445b6db66140aecb3bc822075a6e9bb9d7e33 (diff) | |
download | chromium_src-4b5d64ff3d7d95247ed4f078d8bf585a1726794d.zip chromium_src-4b5d64ff3d7d95247ed4f078d8bf585a1726794d.tar.gz chromium_src-4b5d64ff3d7d95247ed4f078d8bf585a1726794d.tar.bz2 |
Pass down the opener tab when a message channel is opened to an extension.
Also did a bunch of cleanup of ExtensionMessageService. I converted it to
primarily UI-thread habitation, with one function that needs to be on the IO
thread so it can handle a synchronous IPC message.
TEST=N/A
Review URL: http://codereview.chromium.org/99261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15097 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_messages_unittest.cc')
-rw-r--r-- | chrome/browser/extensions/extension_messages_unittest.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/extensions/extension_messages_unittest.cc b/chrome/browser/extensions/extension_messages_unittest.cc index 1ef9f43..606c301 100644 --- a/chrome/browser/extensions/extension_messages_unittest.cc +++ b/chrome/browser/extensions/extension_messages_unittest.cc @@ -59,7 +59,7 @@ TEST_F(RenderViewTest, ExtensionMessagesOnConnect) { ExecuteJavaScript( "chromium.self.onConnect.addListener(function (port) {" " port.onMessage.addListener(doOnMessage);" - " port.postMessage({message: 'onconnect'});" + " port.postMessage({message: 'onconnect from ' + port.tab.url});" "});" "function doOnMessage(msg, port) {" " alert('got: ' + msg.val);" @@ -69,7 +69,8 @@ TEST_F(RenderViewTest, ExtensionMessagesOnConnect) { // Simulate a new connection being opened. const int kPortId = 0; - RendererExtensionBindings::HandleConnect(kPortId); + RendererExtensionBindings::HandleConnect(kPortId, + "{\"url\":\"foo://bar\"}"); // Verify that we handled the new connection by posting a message. const IPC::Message* post_msg = @@ -78,7 +79,7 @@ TEST_F(RenderViewTest, ExtensionMessagesOnConnect) { ASSERT_TRUE(post_msg); ViewHostMsg_ExtensionPostMessage::Param post_params; ViewHostMsg_ExtensionPostMessage::Read(post_msg, &post_params); - EXPECT_EQ("{\"message\":\"onconnect\"}", post_params.b); + EXPECT_EQ("{\"message\":\"onconnect from foo://bar\"}", post_params.b); // Now simulate getting a message back from the channel opener. render_thread_.sink().ClearMessages(); |