summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extension_override_apitest.cc
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-03 05:53:20 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-03 05:53:20 +0000
commit4ca153033f022dc6e11d6094daed41b1ed0a995f (patch)
treef4720517b10953166f84707ca3ec8b82de860884 /chrome/browser/extensions/extension_override_apitest.cc
parent08bd3d71d969061b1588e6a4210f6d74b0ec0c6d (diff)
downloadchromium_src-4ca153033f022dc6e11d6094daed41b1ed0a995f.zip
chromium_src-4ca153033f022dc6e11d6094daed41b1ed0a995f.tar.gz
chromium_src-4ca153033f022dc6e11d6094daed41b1ed0a995f.tar.bz2
Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review.
I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9015022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116122 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_override_apitest.cc')
-rw-r--r--chrome/browser/extensions/extension_override_apitest.cc9
1 files changed, 6 insertions, 3 deletions
diff --git a/chrome/browser/extensions/extension_override_apitest.cc b/chrome/browser/extensions/extension_override_apitest.cc
index a55d57f..00b6b0c 100644
--- a/chrome/browser/extensions/extension_override_apitest.cc
+++ b/chrome/browser/extensions/extension_override_apitest.cc
@@ -14,6 +14,9 @@
#include "chrome/test/base/ui_test_utils.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/web_contents.h"
+
+using content::WebContents;
class ExtensionOverrideTest : public ExtensionApiTest {
protected:
@@ -47,7 +50,7 @@ class ExtensionOverrideTest : public ExtensionApiTest {
// extension URL.
void NavigateToKeyboard() {
ui_test_utils::NavigateToURL(browser(), GURL("chrome://keyboard/"));
- TabContents* tab = browser()->GetSelectedTabContents();
+ WebContents* tab = browser()->GetSelectedWebContents();
ASSERT_TRUE(tab->GetController().GetActiveEntry());
EXPECT_TRUE(tab->GetController().GetActiveEntry()->url().
SchemeIs(chrome::kExtensionScheme));
@@ -62,7 +65,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, OverrideNewtab) {
// Navigate to the new tab page. The overridden new tab page
// will call chrome.test.notifyPass() .
ui_test_utils::NavigateToURL(browser(), GURL("chrome://newtab/"));
- TabContents* tab = browser()->GetSelectedTabContents();
+ WebContents* tab = browser()->GetSelectedWebContents();
ASSERT_TRUE(tab->GetController().GetActiveEntry());
EXPECT_TRUE(tab->GetController().GetActiveEntry()->GetURL().
SchemeIs(chrome::kExtensionScheme));
@@ -89,7 +92,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionOverrideTest, MAYBE_OverrideNewtabIncognito) {
GURL("chrome://newtab/"));
Browser* otr_browser = BrowserList::FindTabbedBrowser(
browser()->profile()->GetOffTheRecordProfile(), false);
- TabContents* tab = otr_browser->GetSelectedTabContents();
+ WebContents* tab = otr_browser->GetSelectedWebContents();
ASSERT_TRUE(tab->GetController().GetActiveEntry());
EXPECT_FALSE(tab->GetController().GetActiveEntry()->GetURL().
SchemeIs(chrome::kExtensionScheme));