diff options
| author | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 19:03:23 +0000 |
|---|---|---|
| committer | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 19:03:23 +0000 |
| commit | 8b001f3e36a29f590e57d46e8e1b357685eb38c1 (patch) | |
| tree | b522039770a7cd9bd77598cf5cc070f984f78ae8 /chrome/browser/extensions/extension_preference_api.cc | |
| parent | 248075e81cfc2a529bcb54cd095f82baee313385 (diff) | |
| download | chromium_src-8b001f3e36a29f590e57d46e8e1b357685eb38c1.zip chromium_src-8b001f3e36a29f590e57d46e8e1b357685eb38c1.tar.gz chromium_src-8b001f3e36a29f590e57d46e8e1b357685eb38c1.tar.bz2 | |
Disable setting incognito prefs for extensions for now.
BUG=60099
TEST=no
Review URL: http://codereview.chromium.org/6990054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86666 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_preference_api.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_preference_api.cc | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/chrome/browser/extensions/extension_preference_api.cc b/chrome/browser/extensions/extension_preference_api.cc index 48b40e6..a45e5b6 100644 --- a/chrome/browser/extensions/extension_preference_api.cc +++ b/chrome/browser/extensions/extension_preference_api.cc @@ -38,7 +38,8 @@ const char kIncognitoSpecific[] = "incognitoSpecific"; const char kLevelOfControl[] = "levelOfControl"; const char kValue[] = "value"; -const char kOnPrefChangeFormat[] = "experimental.preferences.%s.onChange"; +const char kOnPrefChangeFormat[] = + "experimental.preferences.%s.onChange"; const char kIncognitoErrorMessage[] = "You do not have permission to access incognito preferences."; @@ -346,8 +347,10 @@ bool SetPreferenceFunction::RunImpl() { EXTENSION_FUNCTION_VALIDATE(details->Get(kValue, &value)); bool incognito = false; - if (details->HasKey(kIncognito)) - EXTENSION_FUNCTION_VALIDATE(details->GetBoolean(kIncognito, &incognito)); + + // TODO(battre): enable incognito preferences again. + // if (details->HasKey(kIncognito)) + // EXTENSION_FUNCTION_VALIDATE(details->GetBoolean(kIncognito, &incognito)); if (incognito && !include_incognito()) { error_ = kIncognitoErrorMessage; @@ -395,8 +398,10 @@ bool ClearPreferenceFunction::RunImpl() { EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(1, &details)); bool incognito = false; - if (details->HasKey(kIncognito)) - EXTENSION_FUNCTION_VALIDATE(details->GetBoolean(kIncognito, &incognito)); + + // TODO(battre): enable incognito preferences again. + // if (details->HasKey(kIncognito)) + // EXTENSION_FUNCTION_VALIDATE(details->GetBoolean(kIncognito, &incognito)); // We don't check incognito permissions here, as an extension should be always // allowed to clear its own settings. |