Refactor ExtensionService/ExtensionServiceInterface to be more testable

In particular:
- Add various status accessors to ExtensionServiceInterface (e.g.,
  IsExtensionEnabled())
- Convert IsIncognitoEnabled() to take an ID instead of an Extension*.
- Add CheckForUpdates() to ExtensionServiceInterface.
- Remove various unneeded accessors from ExtensionServiceInterface.

Rewrite some sync utility functions to take advantage of the new
interface (although it will be rewritten more in a future CL).

BUG=77995
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80539

Review URL: http://codereview.chromium.org/6720042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80705 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 20 insertions, 15 deletions

diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index a8f55ee..54f70d6 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -63,6 +63,9 @@ class ExtensionServiceInterface {
   virtual void UninstallExtension(const std::string& extension_id,
                                   bool external_uninstall) = 0;
 
+  virtual bool IsExtensionEnabled(const std::string& extension_id) const = 0;
+  virtual bool IsExternalExtensionUninstalled(
+      const std::string& extension_id) const = 0;
   virtual void EnableExtension(const std::string& extension_id) = 0;
   virtual void DisableExtension(const std::string& extension_id) = 0;
 
@@ -71,17 +74,11 @@ class ExtensionServiceInterface {
   virtual void CheckAdminBlacklist() = 0;
   virtual bool HasInstalledExtensions() = 0;
 
-  virtual void SetIsIncognitoEnabled(const Extension* extension,
+  virtual bool IsIncognitoEnabled(const std::string& extension_id) const = 0;
+  virtual void SetIsIncognitoEnabled(const std::string& extension_id,
                                      bool enabled) = 0;
 
-  // TODO(skerner): Change to const ExtensionPrefs& extension_prefs() const,
-  // ExtensionPrefs* mutable_extension_prefs().
-  virtual ExtensionPrefs* extension_prefs() = 0;
-  virtual const ExtensionPrefs& const_extension_prefs() const = 0;
-
-  virtual ExtensionUpdater* updater() = 0;
-
-  virtual Profile* profile() = 0;
+  virtual void CheckForUpdates() = 0;
 };
 
 // Manages installed and running Chromium extensions.
@@ -168,8 +165,9 @@ class ExtensionService
   DefaultApps* default_apps() { return &default_apps_; }
 
   // Whether this extension can run in an incognito window.
-  bool IsIncognitoEnabled(const Extension* extension);
-  virtual void SetIsIncognitoEnabled(const Extension* extension, bool enabled);
+  virtual bool IsIncognitoEnabled(const std::string& extension_id) const;
+  virtual void SetIsIncognitoEnabled(const std::string& extension_id,
+                                     bool enabled);
 
   // Returns true if the given extension can see events and data from another
   // sub-profile (incognito to original profile, or vice versa).
@@ -233,6 +231,10 @@ class ExtensionService
   virtual void UninstallExtension(const std::string& extension_id,
                                   bool external_uninstall);
 
+  virtual bool IsExtensionEnabled(const std::string& extension_id) const;
+  virtual bool IsExternalExtensionUninstalled(
+      const std::string& extension_id) const;
+
   // Enable or disable an extension. No action if the extension is already
   // enabled/disabled.
   virtual void EnableExtension(const std::string& extension_id);
@@ -335,6 +337,8 @@ class ExtensionService
   // set of extensions.
   virtual void CheckAdminBlacklist();
 
+  virtual void CheckForUpdates();
+
   void set_extensions_enabled(bool enabled) { extensions_enabled_ = enabled; }
   bool extensions_enabled() { return extensions_enabled_; }
 
@@ -346,21 +350,22 @@ class ExtensionService
     return show_extensions_prompts_;
   }
 
-  virtual Profile* profile();
+  Profile* profile();
 
   // Profile calls this when it is being destroyed so that we know not to call
   // it.
   void DestroyingProfile();
 
-  virtual ExtensionPrefs* extension_prefs();
-  virtual const ExtensionPrefs& const_extension_prefs() const;
+  // TODO(skerner): Change to const ExtensionPrefs& extension_prefs() const,
+  // ExtensionPrefs* mutable_extension_prefs().
+  ExtensionPrefs* extension_prefs();
 
   // Whether the extension service is ready.
   // TODO(skerner): Get rid of this method.  crbug.com/63756
   bool is_ready() { return ready_; }
 
   // Note that this may return NULL if autoupdate is not turned on.
-  virtual ExtensionUpdater* updater();
+  ExtensionUpdater* updater();
 
   ExtensionToolbarModel* toolbar_model() { return &toolbar_model_; }