diff options
| author | dmazzoni@chromium.org <dmazzoni@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-29 00:48:41 +0000 |
|---|---|---|
| committer | dmazzoni@chromium.org <dmazzoni@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-29 00:48:41 +0000 |
| commit | 6a86a8e320782a0cb35b18dac3d803e09015aaee (patch) | |
| tree | 2fdbc17f5befe515ddb2331fff89612839826a07 /chrome/browser/extensions/extension_service_unittest.cc | |
| parent | 54b92514f78f8af633e86f7bcf7bf446aeffc5cc (diff) | |
| download | chromium_src-6a86a8e320782a0cb35b18dac3d803e09015aaee.zip chromium_src-6a86a8e320782a0cb35b18dac3d803e09015aaee.tar.gz chromium_src-6a86a8e320782a0cb35b18dac3d803e09015aaee.tar.bz2 | |
Make accessibility interactive_ui_tests less brittle
The accessibility interactive_ui_tests were miraculously
surviving on the bots - but when run locally they failed
flakily for me. With this patch I can't make them fail.
1. Fix potential race/flakiness condition by finishing loading
the page first, then loading the accessibility tree - rather than
allowing these to interleave.
2. Add multiple accessibility notifications for tests to listen to
so that tests aren't sensitive to WebKit sending additional unrelated
notifications.
3. Tiny change to the html of one test; it was assuming that
focusable divs don't get an accessible title, but this won't be
true anymore when WebKit bug 94302 lands.
This patch should have no effect in isolation (other than
reducing flakiness), but landing it will make it possible for
WebKit bug 94302 to land without breaking any tests.
BUG=144952
Review URL: https://chromiumcodereview.appspot.com/10870097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153813 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_service_unittest.cc')
0 files changed, 0 insertions, 0 deletions