diff options
| author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-18 18:02:32 +0000 |
|---|---|---|
| committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-18 18:02:32 +0000 |
| commit | 9bdb569251fb3fec30380518e461102e711f5b49 (patch) | |
| tree | 75785907e0d126335983cfaec3487ad54cff2c15 /chrome/browser/extensions/extension_tabs_module.cc | |
| parent | a420dab69867264317f3bfe7ba73268b5f99551c (diff) | |
| download | chromium_src-9bdb569251fb3fec30380518e461102e711f5b49.zip chromium_src-9bdb569251fb3fec30380518e461102e711f5b49.tar.gz chromium_src-9bdb569251fb3fec30380518e461102e711f5b49.tar.bz2 | |
Revert "Extensions: tab.title should not be undefined."
On vista, this change hard breaks tab.title in extensions.
This reverts commit cabda9d732b49ed018821772398d732bbc1af75a (r26586).
TBR=rafaelw
Review URL: http://codereview.chromium.org/207032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26592 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_tabs_module.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_tabs_module.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc index 2d3e70c..12028c2 100644 --- a/chrome/browser/extensions/extension_tabs_module.cc +++ b/chrome/browser/extensions/extension_tabs_module.cc @@ -115,9 +115,10 @@ DictionaryValue* ExtensionTabUtil::CreateTabValue( result->SetString(keys::kStatusKey, GetTabStatusText(status)); result->SetBoolean(keys::kSelectedKey, tab_strip && tab_index == tab_strip->selected_index()); - result->SetString(keys::kTitleKey, UTF16ToWide(contents->GetTitle())); if (status != TAB_LOADING) { + result->SetString(keys::kTitleKey, UTF16ToWide(contents->GetTitle())); + NavigationEntry* entry = contents->controller().GetActiveEntry(); if (entry) { if (entry->favicon().is_valid()) |